From 75a7e2f9e959137ee97a0ea3d5953a7b3cb1cb82 Mon Sep 17 00:00:00 2001 From: Julia Reynolds Date: Tue, 16 Apr 2019 15:14:24 -0400 Subject: [PATCH] Keep a light version of the SBN around No need to keep bitmaps et al when we aren't using them Test: hprof before and after change Fixes: 130434362 Change-Id: Iabe0ee3e8f80dfb165bacfb118a31218c9e58847 --- .../src/android/ext/services/notification/Assistant.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/ExtServices/src/android/ext/services/notification/Assistant.java b/packages/ExtServices/src/android/ext/services/notification/Assistant.java index b2baff5db75b4..7860f36e7d956 100644 --- a/packages/ExtServices/src/android/ext/services/notification/Assistant.java +++ b/packages/ExtServices/src/android/ext/services/notification/Assistant.java @@ -238,7 +238,7 @@ public class Assistant extends NotificationAssistantService { } mSingleThreadExecutor.submit(() -> { NotificationEntry entry = - new NotificationEntry(mPackageManager, sbn, channel, mSmsHelper); + new NotificationEntry(mPackageManager, sbn.cloneLight(), channel, mSmsHelper); SmartActionsHelper.SmartSuggestions suggestions = mSmartActionsHelper.suggest(entry); if (DEBUG) { Log.d(TAG, String.format( @@ -296,7 +296,7 @@ public class Assistant extends NotificationAssistantService { Ranking ranking = getRanking(sbn.getKey(), rankingMap); if (ranking != null && ranking.getChannel() != null) { NotificationEntry entry = new NotificationEntry(mPackageManager, - sbn, ranking.getChannel(), mSmsHelper); + sbn.cloneLight(), ranking.getChannel(), mSmsHelper); String key = getKey( sbn.getPackageName(), sbn.getUserId(), ranking.getChannel().getId()); ChannelImpressions ci = mkeyToImpressions.getOrDefault(key,