Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Optimize layout rendering in layoutlib [DO NOT MERGE]

Browse Source 
The height of a layout should be zero if it is assigned a layout_weight.
This way, the layout is measured only once and prevents spurious errors.

Bug: https://code.google.com/p/android/issues/detail?id=58398
Change-Id: If49a7480e5eb82cb86780e00f2f5b65ee053fc2a
(cherry-picked from 9e5e993c79)
This commit is contained in:
Deepanshu Gupta
2014-01-20 17:02:37 -08:00
parent 02cde9ceeb
commit 5712b5fc3f
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
tools/layoutlib/bridge/src/com/android/layoutlib/bridge/impl/RenderSessionImpl.java
View File

@@ -335,7 +335,7 @@ public class RenderSessionImpl extends RenderAction<SessionParams> {
backgroundView = backgroundLayout; backgroundView = backgroundLayout;
backgroundLayout.setOrientation(LinearLayout.VERTICAL); backgroundLayout.setOrientation(LinearLayout.VERTICAL);
LinearLayout.LayoutParams layoutParams = new LinearLayout.LayoutParams( LinearLayout.LayoutParams layoutParams = new LinearLayout.LayoutParams(
LayoutParams.MATCH_PARENT, LayoutParams.WRAP_CONTENT); LayoutParams.MATCH_PARENT, 0);
layoutParams.weight = 1; layoutParams.weight = 1;
backgroundLayout.setLayoutParams(layoutParams); backgroundLayout.setLayoutParams(layoutParams);
topLayout.addView(backgroundLayout); topLayout.addView(backgroundLayout);
@@ -370,7 +370,7 @@ public class RenderSessionImpl extends RenderAction<SessionParams> {
// content frame // content frame
mContentRoot = new FrameLayout(context); mContentRoot = new FrameLayout(context);
layoutParams = new LinearLayout.LayoutParams( layoutParams = new LinearLayout.LayoutParams(
LayoutParams.MATCH_PARENT, LayoutParams.WRAP_CONTENT); LayoutParams.MATCH_PARENT, 0);
layoutParams.weight = 1; layoutParams.weight = 1;
mContentRoot.setLayoutParams(layoutParams); mContentRoot.setLayoutParams(layoutParams);
backgroundLayout.addView(mContentRoot); backgroundLayout.addView(mContentRoot);