From 56fbd4e123de87f34ef3d41d42273c55c0dcea53 Mon Sep 17 00:00:00 2001 From: Todd Kennedy Date: Thu, 6 Jun 2019 14:47:24 -0700 Subject: [PATCH] Don't abort multi-package install early The multi-package install flow depends upon all of the packages being processed. If we ever skip one, any installation status will never be returned to the installation observer. Fixes: 134632533 Test: adb install-multi-package app1/base.apk app2/base.apk app3/base.apk app4/base.apk Test: adb did not hang and returned proper error "Failure [INSTALL_FAILED_VERSION_DOWNGRADE" Change-Id: I3c0d1df059e1411c2d77f96b8fb656c9d1050ce1 --- .../core/java/com/android/server/pm/PackageManagerService.java | 2 -- 1 file changed, 2 deletions(-) diff --git a/services/core/java/com/android/server/pm/PackageManagerService.java b/services/core/java/com/android/server/pm/PackageManagerService.java index 4a5e61bc7d728..7d5393deb3f84 100644 --- a/services/core/java/com/android/server/pm/PackageManagerService.java +++ b/services/core/java/com/android/server/pm/PackageManagerService.java @@ -15012,7 +15012,6 @@ public class PackageManagerService extends IPackageManager.Stub params.handleStartCopy(); if (params.mRet != INSTALL_SUCCEEDED) { mRet = params.mRet; - break; } } } @@ -15023,7 +15022,6 @@ public class PackageManagerService extends IPackageManager.Stub params.handleReturnCode(); if (params.mRet != INSTALL_SUCCEEDED) { mRet = params.mRet; - break; } } }