Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge "Update language to comply with Android's inclusive language guidance"

Browse Source
This commit is contained in:
Alex Light
2020-08-03 20:39:29 +00:00
committed by Gerrit Code Review
parent af1750e973 7b942c1f31
commit 56f5e6595b
7 changed files with 11 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
core/jni/android_database_SQLiteConnection.cpp
View File

@@ -210,7 +210,8 @@ static void sqliteCustomFunctionCallback(sqlite3_context *context,
// Get the callback function object. // Get the callback function object.
// Create a new local reference to it in case the callback tries to do something // Create a new local reference to it in case the callback tries to do something
// dumb like unregister the function (thereby destroying the global ref) while it is running. // unexpected like unregister the function (thereby destroying the global ref)
// while it is running.
jobject functionObjGlobal = reinterpret_cast<jobject>(sqlite3_user_data(context)); jobject functionObjGlobal = reinterpret_cast<jobject>(sqlite3_user_data(context));
jobject functionObj = env->NewLocalRef(functionObjGlobal); jobject functionObj = env->NewLocalRef(functionObjGlobal);

2
core/jni/android_media_AudioSystem.cpp
View File

@@ -936,7 +936,7 @@ static jint convertAudioPortConfigFromNative(JNIEnv *env,
if (jHandle == NULL) { if (jHandle == NULL) {
return (jint)AUDIO_JAVA_ERROR; return (jint)AUDIO_JAVA_ERROR;
} }
// create dummy port and port config objects with just the correct handle // create placeholder port and port config objects with just the correct handle
// and configuration data. The actual AudioPortConfig objects will be // and configuration data. The actual AudioPortConfig objects will be
// constructed by java code with correct class type (device, mix etc...) // constructed by java code with correct class type (device, mix etc...)
// and reference to AudioPort instance in this client // and reference to AudioPort instance in this client

5
core/jni/android_net_NetUtils.cpp
View File

@@ -93,9 +93,10 @@ static void android_net_utils_attachDropAllBPFFilter(JNIEnv *env, jobject clazz,
static void android_net_utils_detachBPFFilter(JNIEnv *env, jobject clazz, jobject javaFd) static void android_net_utils_detachBPFFilter(JNIEnv *env, jobject clazz, jobject javaFd)
{ {
int dummy = 0; int optval_ignored = 0;
int fd = jniGetFDFromFileDescriptor(env, javaFd); int fd = jniGetFDFromFileDescriptor(env, javaFd);
if (setsockopt(fd, SOL_SOCKET, SO_DETACH_FILTER, &dummy, sizeof(dummy)) != 0) { if (setsockopt(
fd, SOL_SOCKET, SO_DETACH_FILTER, &optval_ignored, sizeof(optval_ignored)) != 0) {
jniThrowExceptionFmt(env, "java/net/SocketException", jniThrowExceptionFmt(env, "java/net/SocketException",
"setsockopt(SO_DETACH_FILTER): %s", strerror(errno)); "setsockopt(SO_DETACH_FILTER): %s", strerror(errno));
} }

2
core/jni/android_os_Debug.cpp
View File

@@ -913,7 +913,7 @@ int register_android_os_Debug(JNIEnv *env)
{ {
jclass clazz = env->FindClass("android/os/Debug$MemoryInfo"); jclass clazz = env->FindClass("android/os/Debug$MemoryInfo");
// Sanity check the number of other statistics expected in Java matches here. // Check the number of other statistics expected in Java matches here.
jfieldID numOtherStats_field = env->GetStaticFieldID(clazz, "NUM_OTHER_STATS", "I"); jfieldID numOtherStats_field = env->GetStaticFieldID(clazz, "NUM_OTHER_STATS", "I");
jint numOtherStats = env->GetStaticIntField(clazz, numOtherStats_field); jint numOtherStats = env->GetStaticIntField(clazz, numOtherStats_field);
jfieldID numDvkStats_field = env->GetStaticFieldID(clazz, "NUM_DVK_STATS", "I"); jfieldID numDvkStats_field = env->GetStaticFieldID(clazz, "NUM_DVK_STATS", "I");

2
core/jni/android_os_Parcel.cpp
View File

@@ -328,7 +328,7 @@ static jbyteArray android_os_Parcel_createByteArray(JNIEnv* env, jclass clazz, j
if (parcel != NULL) { if (parcel != NULL) {
int32_t len = parcel->readInt32(); int32_t len = parcel->readInt32();
// sanity check the stored length against the true data size // Validate the stored length against the true data size
if (len >= 0 && len <= (int32_t)parcel->dataAvail()) { if (len >= 0 && len <= (int32_t)parcel->dataAvail()) {
ret = env->NewByteArray(len); ret = env->NewByteArray(len);

2
core/jni/android_util_Binder.cpp
View File

@@ -957,7 +957,7 @@ static jlong android_os_Binder_clearCallingIdentity()
static void android_os_Binder_restoreCallingIdentity(JNIEnv* env, jobject clazz, jlong token) static void android_os_Binder_restoreCallingIdentity(JNIEnv* env, jobject clazz, jlong token)
{ {
// XXX temporary sanity check to debug crashes. // XXX temporary validation check to debug crashes.
int uid = (int)(token>>32); int uid = (int)(token>>32);
if (uid > 0 && uid < 999) { if (uid > 0 && uid < 999) {
// In Android currently there are no uids in this range. // In Android currently there are no uids in this range.

4
core/jni/android_view_InputQueue.cpp
View File

@@ -176,8 +176,8 @@ void InputQueue::enqueueEvent(InputEvent* event) {
Mutex::Autolock _l(mLock); Mutex::Autolock _l(mLock);
mPendingEvents.push(event); mPendingEvents.push(event);
if (mPendingEvents.size() == 1) { if (mPendingEvents.size() == 1) {
char dummy = 0; char payload = '\0';
int res = TEMP_FAILURE_RETRY(write(mDispatchWriteFd, &dummy, sizeof(dummy))); int res = TEMP_FAILURE_RETRY(write(mDispatchWriteFd, &payload, sizeof(payload)));
if (res < 0 && errno != EAGAIN) { if (res < 0 && errno != EAGAIN) {
ALOGW("Failed writing to dispatch fd: %s", strerror(errno)); ALOGW("Failed writing to dispatch fd: %s", strerror(errno));
} }