diff --git a/core/java/android/service/oemlock/IOemLockService.aidl b/core/java/android/service/oemlock/IOemLockService.aidl index 682e7ee099293..d5e10d6629caa 100644 --- a/core/java/android/service/oemlock/IOemLockService.aidl +++ b/core/java/android/service/oemlock/IOemLockService.aidl @@ -28,7 +28,6 @@ interface IOemLockService { void setOemUnlockAllowedByUser(boolean allowed); boolean isOemUnlockAllowedByUser(); - boolean canUserAllowOemUnlock(); boolean isOemUnlockAllowed(); boolean isDeviceOemUnlocked(); } diff --git a/core/java/android/service/oemlock/OemLockManager.java b/core/java/android/service/oemlock/OemLockManager.java index 3a56d9f1bf4f8..f0d660354167b 100644 --- a/core/java/android/service/oemlock/OemLockManager.java +++ b/core/java/android/service/oemlock/OemLockManager.java @@ -117,24 +117,6 @@ public class OemLockManager { } } - /** - * Returns whether all parties other than the user allow OEM unlock meaning the user can - * directly control whether or not the device can be OEM unlocked. - * - * If this is true, {@link #isOemUnlockAllowedByUser} is the same as {@link #isOemUnlockAllowed} - * - * @return Whether the user can directly control whether the device can be OEM unlocked. - * - * @hide - */ - public boolean canUserAllowOemUnlock() { - try { - return mService.canUserAllowOemUnlock(); - } catch (RemoteException e) { - throw e.rethrowFromSystemServer(); - } - } - /** * @return Whether the bootloader is able to OEM unlock the device. * diff --git a/services/core/java/com/android/server/oemlock/OemLockService.java b/services/core/java/com/android/server/oemlock/OemLockService.java index 5e19b134c4aa8..40c663942e1d0 100644 --- a/services/core/java/com/android/server/oemlock/OemLockService.java +++ b/services/core/java/com/android/server/oemlock/OemLockService.java @@ -149,8 +149,12 @@ public class OemLockService extends SystemService { final long token = Binder.clearCallingIdentity(); try { - if (!canUserAllowOemUnlock()) { - throw new SecurityException("User cannot allow OEM unlock"); + if (!isOemUnlockAllowedByAdmin()) { + throw new SecurityException("Admin does not allow OEM unlock"); + } + + if (!mOemLock.isOemUnlockAllowedByCarrier()) { + throw new SecurityException("Carrier does not allow OEM unlock"); } mOemLock.setOemUnlockAllowedByDevice(allowedByUser); @@ -171,18 +175,6 @@ public class OemLockService extends SystemService { } } - @Override - public boolean canUserAllowOemUnlock() { - enforceOemUnlockReadPermission(); - - final long token = Binder.clearCallingIdentity(); - try { - return isOemUnlockAllowedByAdmin() && mOemLock.isOemUnlockAllowedByCarrier(); - } finally { - Binder.restoreCallingIdentity(token); - } - } - @Override public boolean isOemUnlockAllowed() { enforceOemUnlockReadPermission();