From 8e82c86669beaa1bd8dfe5b2e24a55f03b68d879 Mon Sep 17 00:00:00 2001 From: Josh Tsuji Date: Mon, 28 Jun 2021 11:15:13 -0400 Subject: [PATCH] Null-check tooltip view to avoid race condition crash. I think this happens if you tap the tooltip just as the dialog times out? Can't hurt to check. Fixes: 191281724 Test: crashes at least as infrequently as before, probably less Change-Id: I3c83e775a7fd278dc255242518412ba790625fdb --- .../src/com/android/systemui/volume/VolumeDialogImpl.java | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/packages/SystemUI/src/com/android/systemui/volume/VolumeDialogImpl.java b/packages/SystemUI/src/com/android/systemui/volume/VolumeDialogImpl.java index 407b248cee444..5de7846a820ea 100644 --- a/packages/SystemUI/src/com/android/systemui/volume/VolumeDialogImpl.java +++ b/packages/SystemUI/src/com/android/systemui/volume/VolumeDialogImpl.java @@ -1127,7 +1127,12 @@ public class VolumeDialogImpl implements VolumeDialog, .alpha(0.f) .setStartDelay(0) .setDuration(mDialogHideAnimationDurationMs) - .withEndAction(() -> mODICaptionsTooltipView.setVisibility(INVISIBLE)) + .withEndAction(() -> { + // It might have been nulled out by tryToRemoveCaptionsTooltip. + if (mODICaptionsTooltipView != null) { + mODICaptionsTooltipView.setVisibility(INVISIBLE); + } + }) .start(); } }