From 0940129f60eaf1e4d19a6c9f71aaf65119095a88 Mon Sep 17 00:00:00 2001 From: Yu-Han Yang Date: Thu, 11 Feb 2021 15:19:40 -0800 Subject: [PATCH] Update javadoc for carrierFrequency and AGC Since Android S, carrier frequencies in GnssStatus and GnssMeasurement are required. Also added a comment to clarify AGC value. Bug: 179157665 Bug: 173523109 Test: comment only Change-Id: I1f59bcc0c26739a2057037da766cd0a5206e06ff --- location/java/android/location/GnssMeasurement.java | 11 +++-------- location/java/android/location/GnssStatus.java | 7 +------ 2 files changed, 4 insertions(+), 14 deletions(-) diff --git a/location/java/android/location/GnssMeasurement.java b/location/java/android/location/GnssMeasurement.java index 3dcaffbd27129..242d9a3627db0 100644 --- a/location/java/android/location/GnssMeasurement.java +++ b/location/java/android/location/GnssMeasurement.java @@ -1096,13 +1096,7 @@ public final class GnssMeasurement implements Parcelable { * Gets the carrier frequency of the tracked signal. * *

For example it can be the GPS central frequency for L1 = 1575.45 MHz, or L2 = 1227.60 MHz, - * L5 = 1176.45 MHz, varying GLO channels, etc. If the field is not set, it is the primary - * common use central frequency, e.g. L1 = 1575.45 MHz for GPS. - * - *

For an L1, L5 receiver tracking a satellite on L1 and L5 at the same time, two raw - * measurement objects will be reported for this same satellite, in one of the measurement - * objects, all the values related to L1 will be filled, and in the other all of the values - * related to L5 will be filled. + * L5 = 1176.45 MHz, varying GLO channels, etc. * *

The value is only available if {@link #hasCarrierFrequencyHz()} is {@code true}. * @@ -1382,7 +1376,8 @@ public final class GnssMeasurement implements Parcelable { *

AGC acts as a variable gain amplifier adjusting the power of the incoming signal. The AGC * level may be used to indicate potential interference. Higher gain (and/or lower input power) * shall be output as a positive number. Hence in cases of strong jamming, in the band of this - * signal, this value will go more negative. + * signal, this value will go more negative. This value must be consistent given the same level + * of the incoming signal power. * *

Note: Different hardware designs (e.g. antenna, pre-amplification, or other RF HW * components) may also affect the typical output of of this value on any given hardware design diff --git a/location/java/android/location/GnssStatus.java b/location/java/android/location/GnssStatus.java index b46e8ce2f605c..23390fce1a5f8 100644 --- a/location/java/android/location/GnssStatus.java +++ b/location/java/android/location/GnssStatus.java @@ -284,12 +284,7 @@ public final class GnssStatus implements Parcelable { * Gets the carrier frequency of the signal tracked. * *

For example it can be the GPS central frequency for L1 = 1575.45 MHz, or L2 = 1227.60 - * MHz, L5 = 1176.45 MHz, varying GLO channels, etc. If the field is not set, it is the primary - * common use central frequency, e.g. L1 = 1575.45 MHz for GPS. - * - * For an L1, L5 receiver tracking a satellite on L1 and L5 at the same time, two measurements - * will be reported for this same satellite, in one all the values related to L1 will be - * filled, and in the other all of the values related to L5 will be filled. + * MHz, L5 = 1176.45 MHz, varying GLO channels, etc. * *

The value is only available if {@link #hasCarrierFrequencyHz(int satelliteIndex)} is * {@code true}.