From aac823d704ad0679a2a7c62285e9475ed782f819 Mon Sep 17 00:00:00 2001 From: Jooyung Han Date: Wed, 18 Nov 2020 12:17:50 +0900 Subject: [PATCH] midi: Use std::optional instead of std::unique_ptr Since Android R, Parcel provides read/write methods for "@nullable" values using std::optional. Bug: 149784838 Test: m Change-Id: I5c6a87072ced2f2a3a16df374244bb0aff5f9cb3 --- media/native/midi/MidiDeviceInfo.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/media/native/midi/MidiDeviceInfo.cpp b/media/native/midi/MidiDeviceInfo.cpp index ac68d26c935b4..8a573fba322b1 100644 --- a/media/native/midi/MidiDeviceInfo.cpp +++ b/media/native/midi/MidiDeviceInfo.cpp @@ -90,13 +90,13 @@ status_t MidiDeviceInfo::readFromParcel(const Parcel* parcel) { status_t MidiDeviceInfo::readStringVector( const Parcel* parcel, Vector *vectorPtr, size_t defaultLength) { - std::unique_ptr>> v; + std::optional>> v; status_t result = parcel->readString16Vector(&v); if (result != OK) return result; vectorPtr->clear(); - if (v.get() != nullptr) { + if (v) { for (const auto& iter : *v) { - if (iter.get() != nullptr) { + if (iter) { vectorPtr->push_back(*iter); } else { vectorPtr->push_back(String16());