Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge "Fix a potential thread safety issue in VectorDrawable" into qt-dev

Browse Source
This commit is contained in:
John Reck
2021-06-29 16:47:21 +00:00
committed by Android (Google) Code Review
parent 976266733d e9831122e6
commit 547df6be1e
1 changed files with 7 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
graphics/java/android/graphics/drawable/VectorDrawable.java
View File

@@ -348,15 +348,19 @@ public class VectorDrawable extends Drawable {
private final Rect mTmpBounds = new Rect(); private final Rect mTmpBounds = new Rect();
public VectorDrawable() { public VectorDrawable() {
this(new VectorDrawableState(null), null); this(null, null);
} }
/** /**
* The one constructor to rule them all. This is called by all public * The one constructor to rule them all. This is called by all public
* constructors to set the state and initialize local properties. * constructors to set the state and initialize local properties.
*/ */
private VectorDrawable(@NonNull VectorDrawableState state, @Nullable Resources res) { private VectorDrawable(@Nullable VectorDrawableState state, @Nullable Resources res) {
mVectorState = state; // As the mutable, not-thread-safe native instance is stored in VectorDrawableState, we
// need to always do a defensive copy even if mutate() isn't called. Otherwise
// draw() being called on 2 different VectorDrawable instances could still hit the same
// underlying native object.
mVectorState = new VectorDrawableState(state);
updateLocalState(res); updateLocalState(res);
} }