From eee9764418d13176c9671e453775d476c2206f6c Mon Sep 17 00:00:00 2001 From: Mathieu Chartier Date: Tue, 23 Sep 2014 17:24:30 -0700 Subject: [PATCH] Fix dalvik map names Some maps which should have been dalvik other were incorrectly accounted for in dalvik heap. Bug: 17632563 Change-Id: I90d0bebf700650a445b19c4c72674b2941868d8b --- core/jni/android_os_Debug.cpp | 24 ++++++++---------------- 1 file changed, 8 insertions(+), 16 deletions(-) diff --git a/core/jni/android_os_Debug.cpp b/core/jni/android_os_Debug.cpp index 87ee6184563da..7b3528b238233 100644 --- a/core/jni/android_os_Debug.cpp +++ b/core/jni/android_os_Debug.cpp @@ -271,27 +271,19 @@ static void read_mapinfo(FILE *fp, stats_t* stats) whichHeap = HEAP_DALVIK_OTHER; if (strstr(name, "/dev/ashmem/dalvik-LinearAlloc") == name) { subHeap = HEAP_DALVIK_LINEARALLOC; - } else if ((strstr(name, "/dev/ashmem/dalvik-mark") == name) || - (strstr(name, "/dev/ashmem/dalvik-allocspace alloc space live-bitmap") == name) || - (strstr(name, "/dev/ashmem/dalvik-allocspace alloc space mark-bitmap") == name) || - (strstr(name, "/dev/ashmem/dalvik-card table") == name) || - (strstr(name, "/dev/ashmem/dalvik-allocation stack") == name) || - (strstr(name, "/dev/ashmem/dalvik-live stack") == name) || - (strstr(name, "/dev/ashmem/dalvik-imagespace") == name) || - (strstr(name, "/dev/ashmem/dalvik-bitmap") == name) || - (strstr(name, "/dev/ashmem/dalvik-card-table") == name) || - (strstr(name, "/dev/ashmem/dalvik-mark-stack") == name) || - (strstr(name, "/dev/ashmem/dalvik-aux-structure") == name)) { - subHeap = HEAP_DALVIK_ACCOUNTING; - } else if (strstr(name, "/dev/ashmem/dalvik-large") == name) { + } else if ((strstr(name, "/dev/ashmem/dalvik-alloc space") == name) || + (strstr(name, "/dev/ashmem/dalvik-main space") == name) || + (strstr(name, "/dev/ashmem/dalvik-non moving space") == name)) { + // This is the regular Dalvik heap. + whichHeap = HEAP_DALVIK; + subHeap = HEAP_DALVIK_NORMAL; + } else if (strstr(name, "/dev/ashmem/dalvik-large object space") == name) { whichHeap = HEAP_DALVIK; subHeap = HEAP_DALVIK_LARGE; } else if (strstr(name, "/dev/ashmem/dalvik-jit-code-cache") == name) { subHeap = HEAP_DALVIK_CODE_CACHE; } else { - // This is the regular Dalvik heap. - whichHeap = HEAP_DALVIK; - subHeap = HEAP_DALVIK_NORMAL; + subHeap = HEAP_DALVIK_ACCOUNTING; // Default to accounting. } } else if (strncmp(name, "/dev/ashmem/CursorWindow", 24) == 0) { whichHeap = HEAP_CURSOR;