Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge "better fix for [3028370] GL get error should return a valid error if no context is bound." into gingerbread

Browse Source
This commit is contained in:
Mathias Agopian
2010-09-23 18:14:44 -07:00
committed by Android (Google) Code Review
parent a7bfe6ad76 25b388c43b
commit 524a6d8e9b
3 changed files with 4 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
opengl/libs/EGL/egl.cpp
View File

@@ -428,19 +428,14 @@ static void(*findProcAddress(const char* name,
// ----------------------------------------------------------------------------
static void gl_no_context() {
static int gl_no_context() {
tls_t* tls = getTLS();
if (tls->logCallWithNoContext == EGL_TRUE) {
tls->logCallWithNoContext = EGL_FALSE;
LOGE("call to OpenGL ES API with no current context "
"(logged once per thread)");
}
}
// Always return GL_INVALID_OPERATION from glGetError() when called from
// a thread without a bound context.
static GLenum gl_no_context_glGetError() {
return GL_INVALID_OPERATION;
return 0;
}
static void early_egl_init(void)
@@ -454,8 +449,6 @@ static void early_egl_init(void)
addr,
sizeof(gHooksNoContext));
gHooksNoContext.gl.glGetError = gl_no_context_glGetError;
setGlThreadSpecific(&gHooksNoContext);
}

1
opengl/libs/GLES2/gl2.cpp
View File

@@ -58,6 +58,7 @@ using namespace android;
"ldr r12, [r12, %[tls]] \n" \
"cmp r12, #0 \n" \
"ldrne pc, [r12, %[api]] \n" \
"mov r0, #0 \n" \
"bx lr \n" \
: \
: [tls] "J"(TLS_SLOT_OPENGL_API*4), \

1
opengl/libs/GLES_CM/gl.cpp
View File

@@ -114,6 +114,7 @@ GL_API void GL_APIENTRY glWeightPointerOESBounds(GLint size, GLenum type,
"ldr r12, [r12, %[tls]] \n" \
"cmp r12, #0 \n" \
"ldrne pc, [r12, %[api]] \n" \
"mov r0, #0 \n" \
"bx lr \n" \
: \
: [tls] "J"(TLS_SLOT_OPENGL_API*4), \