From 0b30c5a64a59724d8935ef6e7a772999111a4eb3 Mon Sep 17 00:00:00 2001 From: Jean-Michel Trivi Date: Tue, 28 Feb 2017 14:56:04 -0800 Subject: [PATCH] AudioService: fix volume shaper release Catch exception when applying a volume shaper to cancel any remaining volume shaper for release Test: see bug Bug: 35842573 Change-Id: Ic724a43fad6df599540369c095498c8adb2c73a8 --- .../com/android/server/audio/PlaybackActivityMonitor.java | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/services/core/java/com/android/server/audio/PlaybackActivityMonitor.java b/services/core/java/com/android/server/audio/PlaybackActivityMonitor.java index d648dd82dc9aa..4404dcf5e01c1 100644 --- a/services/core/java/com/android/server/audio/PlaybackActivityMonitor.java +++ b/services/core/java/com/android/server/audio/PlaybackActivityMonitor.java @@ -152,9 +152,11 @@ public final class PlaybackActivityMonitor synchronized(mPlayerLock) { final AudioPlaybackConfiguration apc = mPlayers.get(new Integer(piid)); if (checkConfigurationCaller(piid, apc, binderUid)) { - apc.getPlayerProxy().applyVolumeShaper( - DUCK_ID, - TERMINATE); + try { + apc.getPlayerProxy().applyVolumeShaper( + DUCK_ID, + TERMINATE); + } catch (Exception e) { /* silent failure, happens happens with binder failure */ } mPlayers.remove(new Integer(piid)); } else { Log.e(TAG, "Error releasing player " + piid);