diff --git a/packages/SettingsLib/src/com/android/settingslib/wifi/AccessPointPreference.java b/packages/SettingsLib/src/com/android/settingslib/wifi/AccessPointPreference.java index c24cdae2dca5c..9ed8de059996c 100644 --- a/packages/SettingsLib/src/com/android/settingslib/wifi/AccessPointPreference.java +++ b/packages/SettingsLib/src/com/android/settingslib/wifi/AccessPointPreference.java @@ -160,7 +160,7 @@ public class AccessPointPreference extends Preference { drawable.setLevel(mLevel); } - mTitleView = (TextView) view.findViewById(com.android.internal.R.id.title); + mTitleView = (TextView) view.findViewById(android.R.id.title); if (mTitleView != null) { // Attach to the end of the title view mTitleView.setCompoundDrawablesRelativeWithIntrinsicBounds(null, null, mBadge, null); @@ -231,12 +231,7 @@ public class AccessPointPreference extends Preference { * Updates the title and summary; may indirectly call notifyChanged(). */ public void refresh() { - if (mForSavedNetworks) { - setTitle(mAccessPoint.getConfigName()); - } else { - setTitle(mAccessPoint.getSsid()); - } - + setTitle(this, mAccessPoint, mForSavedNetworks); final Context context = getContext(); int level = mAccessPoint.getLevel(); int wifiSpeed = mAccessPoint.getSpeed(); @@ -265,6 +260,15 @@ public class AccessPointPreference extends Preference { } } + @VisibleForTesting + static void setTitle(AccessPointPreference preference, AccessPoint ap, boolean savedNetworks) { + if (savedNetworks) { + preference.setTitle(ap.getConfigName()); + } else { + preference.setTitle(ap.getSsidStr()); + } + } + /** * Helper method to generate content description string. */ diff --git a/packages/SettingsLib/tests/robotests/src/com/android/settingslib/wifi/AccessPointPreferenceTest.java b/packages/SettingsLib/tests/robotests/src/com/android/settingslib/wifi/AccessPointPreferenceTest.java index 6cfdc28d54004..af0b69c0a7cbd 100644 --- a/packages/SettingsLib/tests/robotests/src/com/android/settingslib/wifi/AccessPointPreferenceTest.java +++ b/packages/SettingsLib/tests/robotests/src/com/android/settingslib/wifi/AccessPointPreferenceTest.java @@ -17,6 +17,7 @@ package com.android.settingslib.wifi; import static com.google.common.truth.Truth.assertThat; import static org.mockito.Mockito.mock; +import static org.mockito.Mockito.verify; import static org.mockito.Mockito.when; import android.content.Context; @@ -80,4 +81,19 @@ public class AccessPointPreferenceTest { RuntimeEnvironment.application, pref, ap)) .isEqualTo("ssid,connected,Wifi signal full.,Secure network"); } + + @Test + public void refresh_setTitle_shouldUseSsidString() { + final String ssid = "ssid"; + final String summary = "connected"; + final int security = AccessPoint.SECURITY_WEP; + final AccessPoint ap = new TestAccessPointBuilder(mContext) + .setSsid(ssid) + .setSecurity(security) + .build(); + final AccessPointPreference preference = mock(AccessPointPreference.class); + + AccessPointPreference.setTitle(preference, ap, false /* savedNetwork */); + verify(preference).setTitle(ssid); + } }