From 3e33da67d47fb78356cc9d3eabaad3c1198acc1f Mon Sep 17 00:00:00 2001 From: Mike Digman Date: Wed, 14 Mar 2018 16:25:11 -0700 Subject: [PATCH] Add rotation logs to help debug bug reports Debug logs should be turned off for release Change-Id: I8d9f1ee1e46d014669def25dd47c3a151545afc6 Fixes: 74961129 Test: manual --- .../statusbar/phone/NavigationBarFragment.java | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/packages/SystemUI/src/com/android/systemui/statusbar/phone/NavigationBarFragment.java b/packages/SystemUI/src/com/android/systemui/statusbar/phone/NavigationBarFragment.java index c5781d9a46c16..91483bcd358c1 100644 --- a/packages/SystemUI/src/com/android/systemui/statusbar/phone/NavigationBarFragment.java +++ b/packages/SystemUI/src/com/android/systemui/statusbar/phone/NavigationBarFragment.java @@ -112,6 +112,7 @@ public class NavigationBarFragment extends Fragment implements Callbacks { public static final String TAG = "NavigationBar"; private static final boolean DEBUG = false; + private static final boolean DEBUG_ROTATION = true; private static final String EXTRA_DISABLE_STATE = "disabled_state"; private final static int BUTTON_FADE_IN_OUT_DURATION_MS = 100; @@ -396,6 +397,16 @@ public class NavigationBarFragment extends Fragment implements Callbacks { @Override public void onRotationProposal(final int rotation, boolean isValid) { + final int winRotation = mWindowManager.getDefaultDisplay().getRotation(); + if (DEBUG_ROTATION) { + Log.v(TAG, "onRotationProposal proposedRotation=" + Surface.rotationToString(rotation) + + ", winRotation=" + Surface.rotationToString(winRotation) + + ", isValid=" + isValid + ", mNavBarWindowState=" + + StatusBarManager.windowStateToString(mNavigationBarWindowState) + + ", isRotateButtonVisible=" + (mNavigationBarView == null ? "null" : + mNavigationBarView.isRotateButtonVisible())); + } + // This method will be called on rotation suggestion changes even if the proposed rotation // is not valid for the top app. Use invalid rotation choices as a signal to remove the // rotate button if shown. @@ -405,7 +416,6 @@ public class NavigationBarFragment extends Fragment implements Callbacks { } // If window rotation matches suggested rotation, remove any current suggestions - final int winRotation = mWindowManager.getDefaultDisplay().getRotation(); if (rotation == winRotation) { getView().removeCallbacks(mRemoveRotationProposal); setRotateSuggestionButtonState(false);