From 38e7a60fd7fecdf1c6593724111a92147b4c50ff Mon Sep 17 00:00:00 2001 From: Christopher Tate Date: Tue, 3 Sep 2013 16:57:34 -0700 Subject: [PATCH] Sanity check users before committing new Android ID In creation/deletion cycling we can wind up racing and attempting to establish the Android ID on first access *after* the user has already been deleted. Cope gracefully with this outcome. Bug 10608503 Change-Id: I169d5052e5a2e354ce0e1f61258e45e31f5ba171 --- .../android/providers/settings/SettingsProvider.java | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/packages/SettingsProvider/src/com/android/providers/settings/SettingsProvider.java b/packages/SettingsProvider/src/com/android/providers/settings/SettingsProvider.java index 67539222e0da7..a5dab33d0fdf2 100644 --- a/packages/SettingsProvider/src/com/android/providers/settings/SettingsProvider.java +++ b/packages/SettingsProvider/src/com/android/providers/settings/SettingsProvider.java @@ -33,6 +33,7 @@ import android.content.Context; import android.content.Intent; import android.content.IntentFilter; import android.content.pm.PackageManager; +import android.content.pm.UserInfo; import android.content.res.AssetFileDescriptor; import android.database.AbstractCursor; import android.database.Cursor; @@ -477,6 +478,13 @@ public class SettingsProvider extends ContentProvider { try { final String value = c.moveToNext() ? c.getString(0) : null; if (value == null) { + // sanity-check the user before touching the db + final UserInfo user = mUserManager.getUserInfo(userHandle); + if (user == null) { + // can happen due to races when deleting users; treat as benign + return false; + } + final SecureRandom random = new SecureRandom(); final String newAndroidIdValue = Long.toHexString(random.nextLong()); final ContentValues values = new ContentValues(); @@ -490,7 +498,7 @@ public class SettingsProvider extends ContentProvider { Slog.d(TAG, "Generated and saved new ANDROID_ID [" + newAndroidIdValue + "] for user " + userHandle); // Write a dropbox entry if it's a restricted profile - if (mUserManager.getUserInfo(userHandle).isRestricted()) { + if (user.isRestricted()) { DropBoxManager dbm = (DropBoxManager) getContext().getSystemService(Context.DROPBOX_SERVICE); if (dbm != null && dbm.isTagEnabled(DROPBOX_TAG_USERLOG)) {