From 5112e20135222d7442a86d1bfe2d54dc071aa50c Mon Sep 17 00:00:00 2001 From: Tony Huang Date: Wed, 7 Sep 2022 15:21:39 +0800 Subject: [PATCH] Fix divider dismiss position wrong on potrait When we calculate dismiss target, it will deduce nav bar size from total height. Remove this rule to make divider always move to end of screen. Fix: 232858513 Test: manual Test: pass existing tests Change-Id: I34cf12f242daa31bd4dd7d4b202fc43ac0d752b4 --- .../com/android/internal/policy/DividerSnapAlgorithm.java | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/core/java/com/android/internal/policy/DividerSnapAlgorithm.java b/core/java/com/android/internal/policy/DividerSnapAlgorithm.java index 527286cf000ef..a065e2b78d80c 100644 --- a/core/java/com/android/internal/policy/DividerSnapAlgorithm.java +++ b/core/java/com/android/internal/policy/DividerSnapAlgorithm.java @@ -287,7 +287,6 @@ public class DividerSnapAlgorithm { int dividerMax = isHorizontalDivision ? mDisplayHeight : mDisplayWidth; - int navBarSize = isHorizontalDivision ? mInsets.bottom : mInsets.right; int startPos = -mDividerSize; if (dockedSide == DOCKED_RIGHT) { startPos += mInsets.left; @@ -308,8 +307,7 @@ public class DividerSnapAlgorithm { addMinimizedTarget(isHorizontalDivision, dockedSide); break; } - mTargets.add(new SnapTarget(dividerMax - navBarSize, dividerMax, - SnapTarget.FLAG_DISMISS_END, 0.35f)); + mTargets.add(new SnapTarget(dividerMax, dividerMax, SnapTarget.FLAG_DISMISS_END, 0.35f)); } private void addNonDismissingTargets(boolean isHorizontalDivision, int topPosition,