From 5029b93f4f31873f28b4bf16314540f1519aa602 Mon Sep 17 00:00:00 2001 From: Yuri Lin Date: Thu, 3 Aug 2023 17:17:52 -0400 Subject: [PATCH] Disable overlay app notification launch flicker tests These tests do not currently have any animated notification launch due to the keyguard being occluded. In order to instrument these correctly, we would need to have a correct animation and CUJ for this scenario. Bug: 294418322 Bug: 290577455 Test: only disabling tests Change-Id: I92f9d3e21d77f153bd5ff631c17e0d461818394a --- ...omLockscreenNotificationWithOverlayApp3ButtonNavLandscape.kt | 2 ++ ...romLockscreenNotificationWithOverlayApp3ButtonNavPortrait.kt | 2 ++ ...mLockscreenNotificationWithOverlayAppGesturalNavLandscape.kt | 2 ++ ...omLockscreenNotificationWithOverlayAppGesturalNavPortrait.kt | 2 ++ 4 files changed, 8 insertions(+) diff --git a/tests/FlickerTests/src/com/android/server/wm/flicker/service/notification/flicker/OpenAppFromLockscreenNotificationWithOverlayApp3ButtonNavLandscape.kt b/tests/FlickerTests/src/com/android/server/wm/flicker/service/notification/flicker/OpenAppFromLockscreenNotificationWithOverlayApp3ButtonNavLandscape.kt index b34da72ea5d6b..4adcc8bf5f0b5 100644 --- a/tests/FlickerTests/src/com/android/server/wm/flicker/service/notification/flicker/OpenAppFromLockscreenNotificationWithOverlayApp3ButtonNavLandscape.kt +++ b/tests/FlickerTests/src/com/android/server/wm/flicker/service/notification/flicker/OpenAppFromLockscreenNotificationWithOverlayApp3ButtonNavLandscape.kt @@ -25,10 +25,12 @@ import android.tools.common.flicker.config.FlickerConfig import android.tools.common.flicker.config.FlickerServiceConfig import android.tools.device.flicker.junit.FlickerServiceJUnit4ClassRunner import com.android.server.wm.flicker.service.notification.scenarios.OpenAppFromLockscreenNotificationWithOverlayApp +import org.junit.Ignore import org.junit.Test import org.junit.runner.RunWith @RunWith(FlickerServiceJUnit4ClassRunner::class) +@Ignore("b/294418322: no notification launch animation exists when keyguard is occluded") class OpenAppFromLockscreenNotificationWithOverlayApp3ButtonNavLandscape : OpenAppFromLockscreenNotificationWithOverlayApp(NavBar.MODE_3BUTTON, Rotation.ROTATION_90) { @ExpectedScenarios(["APP_LAUNCH_FROM_NOTIFICATION"]) diff --git a/tests/FlickerTests/src/com/android/server/wm/flicker/service/notification/flicker/OpenAppFromLockscreenNotificationWithOverlayApp3ButtonNavPortrait.kt b/tests/FlickerTests/src/com/android/server/wm/flicker/service/notification/flicker/OpenAppFromLockscreenNotificationWithOverlayApp3ButtonNavPortrait.kt index b1638979cd0d5..f7211e7287cf0 100644 --- a/tests/FlickerTests/src/com/android/server/wm/flicker/service/notification/flicker/OpenAppFromLockscreenNotificationWithOverlayApp3ButtonNavPortrait.kt +++ b/tests/FlickerTests/src/com/android/server/wm/flicker/service/notification/flicker/OpenAppFromLockscreenNotificationWithOverlayApp3ButtonNavPortrait.kt @@ -25,10 +25,12 @@ import android.tools.common.flicker.config.FlickerConfig import android.tools.common.flicker.config.FlickerServiceConfig import android.tools.device.flicker.junit.FlickerServiceJUnit4ClassRunner import com.android.server.wm.flicker.service.notification.scenarios.OpenAppFromLockscreenNotificationWithOverlayApp +import org.junit.Ignore import org.junit.Test import org.junit.runner.RunWith @RunWith(FlickerServiceJUnit4ClassRunner::class) +@Ignore("b/294418322: no notification launch animation exists when keyguard is occluded") class OpenAppFromLockscreenNotificationWithOverlayApp3ButtonNavPortrait : OpenAppFromLockscreenNotificationWithOverlayApp(NavBar.MODE_3BUTTON, Rotation.ROTATION_0) { @ExpectedScenarios(["APP_LAUNCH_FROM_NOTIFICATION"]) diff --git a/tests/FlickerTests/src/com/android/server/wm/flicker/service/notification/flicker/OpenAppFromLockscreenNotificationWithOverlayAppGesturalNavLandscape.kt b/tests/FlickerTests/src/com/android/server/wm/flicker/service/notification/flicker/OpenAppFromLockscreenNotificationWithOverlayAppGesturalNavLandscape.kt index 19b533ed57af5..1ade9560d90f5 100644 --- a/tests/FlickerTests/src/com/android/server/wm/flicker/service/notification/flicker/OpenAppFromLockscreenNotificationWithOverlayAppGesturalNavLandscape.kt +++ b/tests/FlickerTests/src/com/android/server/wm/flicker/service/notification/flicker/OpenAppFromLockscreenNotificationWithOverlayAppGesturalNavLandscape.kt @@ -25,10 +25,12 @@ import android.tools.common.flicker.config.FlickerConfig import android.tools.common.flicker.config.FlickerServiceConfig import android.tools.device.flicker.junit.FlickerServiceJUnit4ClassRunner import com.android.server.wm.flicker.service.notification.scenarios.OpenAppFromLockscreenNotificationWithOverlayApp +import org.junit.Ignore import org.junit.Test import org.junit.runner.RunWith @RunWith(FlickerServiceJUnit4ClassRunner::class) +@Ignore("b/294418322: no notification launch animation exists when keyguard is occluded") class OpenAppFromLockscreenNotificationWithOverlayAppGesturalNavLandscape : OpenAppFromLockscreenNotificationWithOverlayApp(NavBar.MODE_GESTURAL, Rotation.ROTATION_90) { @ExpectedScenarios(["APP_LAUNCH_FROM_NOTIFICATION"]) diff --git a/tests/FlickerTests/src/com/android/server/wm/flicker/service/notification/flicker/OpenAppFromLockscreenNotificationWithOverlayAppGesturalNavPortrait.kt b/tests/FlickerTests/src/com/android/server/wm/flicker/service/notification/flicker/OpenAppFromLockscreenNotificationWithOverlayAppGesturalNavPortrait.kt index c9ed4f42af06b..ea26f0867c7fa 100644 --- a/tests/FlickerTests/src/com/android/server/wm/flicker/service/notification/flicker/OpenAppFromLockscreenNotificationWithOverlayAppGesturalNavPortrait.kt +++ b/tests/FlickerTests/src/com/android/server/wm/flicker/service/notification/flicker/OpenAppFromLockscreenNotificationWithOverlayAppGesturalNavPortrait.kt @@ -25,10 +25,12 @@ import android.tools.common.flicker.config.FlickerConfig import android.tools.common.flicker.config.FlickerServiceConfig import android.tools.device.flicker.junit.FlickerServiceJUnit4ClassRunner import com.android.server.wm.flicker.service.notification.scenarios.OpenAppFromLockscreenNotificationWithOverlayApp +import org.junit.Ignore import org.junit.Test import org.junit.runner.RunWith @RunWith(FlickerServiceJUnit4ClassRunner::class) +@Ignore("b/294418322: no notification launch animation exists when keyguard is occluded") class OpenAppFromLockscreenNotificationWithOverlayAppGesturalNavPortrait : OpenAppFromLockscreenNotificationWithOverlayApp(NavBar.MODE_GESTURAL, Rotation.ROTATION_0) { @ExpectedScenarios(["APP_LAUNCH_FROM_NOTIFICATION"])