From 83877eb559a4bd0682500eb7024f4cecf4c2865b Mon Sep 17 00:00:00 2001 From: Michael Wright Date: Thu, 18 Feb 2021 22:57:41 +0000 Subject: [PATCH] Remove display tests from presubmit. They seem to be leaving the system in a bad state, eventually resulting in an OOM / allocation failure due to fragmentation. Bug: 180636644 Test: atest services/tests/servicestests/src/com/android/server/display/ Change-Id: Iead04a9a6a8569648f1c63a66446e3c60fd38739 --- .../server/display/AutomaticBrightnessControllerTest.java | 2 -- .../android/server/display/BrightnessMappingStrategyTest.java | 2 -- .../src/com/android/server/display/DisplayModeDirectorTest.java | 2 -- .../src/com/android/server/display/PersistentDataStoreTest.java | 2 -- 4 files changed, 8 deletions(-) diff --git a/services/tests/servicestests/src/com/android/server/display/AutomaticBrightnessControllerTest.java b/services/tests/servicestests/src/com/android/server/display/AutomaticBrightnessControllerTest.java index 732c08c98f681..23a4c2f417c5b 100644 --- a/services/tests/servicestests/src/com/android/server/display/AutomaticBrightnessControllerTest.java +++ b/services/tests/servicestests/src/com/android/server/display/AutomaticBrightnessControllerTest.java @@ -30,7 +30,6 @@ import android.hardware.SensorEventListener; import android.hardware.SensorManager; import android.hardware.display.DisplayManagerInternal.DisplayPowerRequest; import android.os.Handler; -import android.platform.test.annotations.Presubmit; import androidx.test.InstrumentationRegistry; import androidx.test.filters.SmallTest; @@ -44,7 +43,6 @@ import org.mockito.Mock; import org.mockito.MockitoAnnotations; @SmallTest -@Presubmit @RunWith(AndroidJUnit4.class) public class AutomaticBrightnessControllerTest { private static final float BRIGHTNESS_MIN_FLOAT = 0.0f; diff --git a/services/tests/servicestests/src/com/android/server/display/BrightnessMappingStrategyTest.java b/services/tests/servicestests/src/com/android/server/display/BrightnessMappingStrategyTest.java index 9396ed2564096..f0b4f1bec77b9 100644 --- a/services/tests/servicestests/src/com/android/server/display/BrightnessMappingStrategyTest.java +++ b/services/tests/servicestests/src/com/android/server/display/BrightnessMappingStrategyTest.java @@ -30,7 +30,6 @@ import android.content.res.Resources; import android.content.res.TypedArray; import android.hardware.display.BrightnessConfiguration; import android.os.PowerManager; -import android.platform.test.annotations.Presubmit; import android.util.MathUtils; import android.util.Spline; @@ -43,7 +42,6 @@ import org.junit.runner.RunWith; import java.util.Arrays; @SmallTest -@Presubmit @RunWith(AndroidJUnit4.class) public class BrightnessMappingStrategyTest { diff --git a/services/tests/servicestests/src/com/android/server/display/DisplayModeDirectorTest.java b/services/tests/servicestests/src/com/android/server/display/DisplayModeDirectorTest.java index ee0f2e8c6f6a5..81b2381cd629d 100644 --- a/services/tests/servicestests/src/com/android/server/display/DisplayModeDirectorTest.java +++ b/services/tests/servicestests/src/com/android/server/display/DisplayModeDirectorTest.java @@ -47,7 +47,6 @@ import android.hardware.SensorManager; import android.hardware.display.DisplayManager; import android.os.Handler; import android.os.Looper; -import android.platform.test.annotations.Presubmit; import android.provider.DeviceConfig; import android.provider.Settings; import android.test.mock.MockContentResolver; @@ -83,7 +82,6 @@ import java.util.concurrent.TimeUnit; import java.util.stream.Collectors; @SmallTest -@Presubmit @RunWith(AndroidJUnit4.class) public class DisplayModeDirectorTest { // The tolerance within which we consider something approximately equals. diff --git a/services/tests/servicestests/src/com/android/server/display/PersistentDataStoreTest.java b/services/tests/servicestests/src/com/android/server/display/PersistentDataStoreTest.java index d72606ac44e51..196454bd32cec 100644 --- a/services/tests/servicestests/src/com/android/server/display/PersistentDataStoreTest.java +++ b/services/tests/servicestests/src/com/android/server/display/PersistentDataStoreTest.java @@ -22,7 +22,6 @@ import static org.junit.Assert.assertNull; import static org.junit.Assert.assertTrue; import android.hardware.display.BrightnessConfiguration; -import android.platform.test.annotations.Presubmit; import android.util.Pair; import androidx.test.filters.SmallTest; @@ -41,7 +40,6 @@ import java.io.OutputStream; import java.nio.charset.StandardCharsets; @SmallTest -@Presubmit @RunWith(AndroidJUnit4.class) public class PersistentDataStoreTest { private PersistentDataStore mDataStore;