From 4e73aea7189a61105d7cd3cef4826302c553802b Mon Sep 17 00:00:00 2001 From: JW Wang Date: Tue, 5 Oct 2021 17:27:33 +0800 Subject: [PATCH] Remove the PackageManager.INSTALL_UNKNOWN check (3/n) Though unlikely, the notification will never be sent and the install process will stuck forever if one of params.mRet equlas PackageManager.INSTALL_UNKNOWN. We should just treat PackageManager.INSTALL_UNKNOWN as failure. Bug: 203026561 Test: atest CtsStagedInstallHostTestCases Change-Id: Ib7070ce89a667bf8a5ab2ceed6b0cc4c7fac44c9 --- .../core/java/com/android/server/pm/VerificationParams.java | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/services/core/java/com/android/server/pm/VerificationParams.java b/services/core/java/com/android/server/pm/VerificationParams.java index ed15e6931fead..c5569cd53da10 100644 --- a/services/core/java/com/android/server/pm/VerificationParams.java +++ b/services/core/java/com/android/server/pm/VerificationParams.java @@ -758,9 +758,7 @@ final class VerificationParams extends HandlerParams { String errorMsg = null; for (VerificationParams params : mVerificationState) { int status = params.mRet; - if (status == PackageManager.INSTALL_UNKNOWN) { - return; - } else if (status != PackageManager.INSTALL_SUCCEEDED) { + if (status != PackageManager.INSTALL_SUCCEEDED) { completeStatus = status; errorMsg = params.mErrorMessage; break;