From ccc63ec80fec3a2e39ce8e1f41035e30de8d737b Mon Sep 17 00:00:00 2001 From: Dianne Hackborn Date: Tue, 30 May 2017 11:04:23 -0700 Subject: [PATCH] Work on issue #62095840: NPE in JobParamteres in the background Crash early if an app calls jobFinished() with null params. Test: manual Change-Id: Icc2cf241edaad00bc5bd49d07a431627bbd76524 --- core/java/android/app/job/JobServiceEngine.java | 3 +++ 1 file changed, 3 insertions(+) diff --git a/core/java/android/app/job/JobServiceEngine.java b/core/java/android/app/job/JobServiceEngine.java index b0ec6502c4b1b..ab94da8436358 100644 --- a/core/java/android/app/job/JobServiceEngine.java +++ b/core/java/android/app/job/JobServiceEngine.java @@ -210,6 +210,9 @@ public abstract class JobServiceEngine { * information. */ public void jobFinished(JobParameters params, boolean needsReschedule) { + if (params == null) { + throw new NullPointerException("params"); + } Message m = Message.obtain(mHandler, MSG_JOB_FINISHED, params); m.arg2 = needsReschedule ? 1 : 0; m.sendToTarget();