From 4d28f3f89de2b63449c439168e2e372eb6adfc15 Mon Sep 17 00:00:00 2001 From: Lucas Dupin Date: Mon, 7 Feb 2022 14:51:58 -0800 Subject: [PATCH] Make IRemoteAnimationFinishedCallback oneway RA#onAnimationFinished() has been called from the UI thread when animations finish, causing missed frames (in at least 7 isolated places in SystemUI.) On top of that, this method returns void, and it doesn't seem like there's good reason for halting the main thread until it finishes. IRemoteAnimationFinishedCallback should follow the same pattern that IRemoteAnimationRunner does, not blocking the caller. Bug: 191971782 Test: https://ui.perfetto.dev/#!/?s=556228b5c78df93f1721f62b97a2715d9dd579602bc2c9c0c9812265bdfaec9 Change-Id: Ia257dc4cff64ced20727de9e514fffe3e0ec6186 --- core/java/android/view/IRemoteAnimationFinishedCallback.aidl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/core/java/android/view/IRemoteAnimationFinishedCallback.aidl b/core/java/android/view/IRemoteAnimationFinishedCallback.aidl index a99162b6c857f..3db2d2d5f3651 100644 --- a/core/java/android/view/IRemoteAnimationFinishedCallback.aidl +++ b/core/java/android/view/IRemoteAnimationFinishedCallback.aidl @@ -22,7 +22,7 @@ package android.view; * @see IRemoteAnimationRunner * {@hide} */ -interface IRemoteAnimationFinishedCallback { +oneway interface IRemoteAnimationFinishedCallback { @UnsupportedAppUsage void onAnimationFinished(); }