Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge "MediaCodec: throw CryptoException with more error info"

Browse Source
This commit is contained in:
Robert Shih
2022-12-20 08:48:06 +00:00
committed by Gerrit Code Review
parent 319863cc4f 57f369a086
commit 4cbe13c73f
1 changed files with 7 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
media/jni/android_media_MediaCodec.cpp
View File

@@ -1285,7 +1285,7 @@ static void throwCryptoException(JNIEnv *env, status_t err, const char *msg,
CHECK(clazz.get() != NULL); CHECK(clazz.get() != NULL);
jmethodID constructID = jmethodID constructID =
env->GetMethodID(clazz.get(), "<init>", "(ILjava/lang/String;)V"); env->GetMethodID(clazz.get(), "<init>", "(Ljava/lang/String;IIII)V");
CHECK(constructID != NULL); CHECK(constructID != NULL);
std::string defaultMsg = "Unknown Error"; std::string defaultMsg = "Unknown Error";
@@ -1335,14 +1335,14 @@ static void throwCryptoException(JNIEnv *env, status_t err, const char *msg,
break; break;
} }
std::string msgStr(msg != NULL ? msg : defaultMsg.c_str()); std::string originalMsg(msg != NULL ? msg : defaultMsg.c_str());
if (crypto != NULL) { DrmStatus dStatus(err, originalMsg.c_str());
msgStr = DrmUtils::GetExceptionMessage(err, msgStr.c_str(), crypto); std::string detailedMsg(DrmUtils::GetExceptionMessage(dStatus, defaultMsg.c_str(), crypto));
} jstring msgObj = env->NewStringUTF(detailedMsg.c_str());
jstring msgObj = env->NewStringUTF(msgStr.c_str());
jthrowable exception = jthrowable exception =
(jthrowable)env->NewObject(clazz.get(), constructID, jerr, msgObj); (jthrowable)env->NewObject(clazz.get(), constructID, msgObj, jerr,
dStatus.getCdmErr(), dStatus.getOemErr(), dStatus.getContext());
env->Throw(exception); env->Throw(exception);
} }