From eaf6cc9c6bd4782c77e93fb0e6ac6104d25fe159 Mon Sep 17 00:00:00 2001 From: Shawn Lee Date: Thu, 2 Feb 2023 14:53:38 -0800 Subject: [PATCH] Fixed swipe down while shade expanding not expanding QS Modified check for deferring touches on QQS area to shade while collapsing to make sure the last fling wasn't for expansion Bug: 266156260 Test: manual and atest Change-Id: Ibec4d868dacd9125c09443c6d4032eb14f3b7db8 --- .../systemui/shade/NotificationPanelViewController.java | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/packages/SystemUI/src/com/android/systemui/shade/NotificationPanelViewController.java b/packages/SystemUI/src/com/android/systemui/shade/NotificationPanelViewController.java index 6c04eb7c4400d..b10e8dfa3d74b 100644 --- a/packages/SystemUI/src/com/android/systemui/shade/NotificationPanelViewController.java +++ b/packages/SystemUI/src/com/android/systemui/shade/NotificationPanelViewController.java @@ -685,6 +685,7 @@ public final class NotificationPanelViewController implements Dumpable { private boolean mInstantExpanding; private boolean mAnimateAfterExpanding; private boolean mIsFlinging; + private boolean mLastFlingWasExpanding; private String mViewName; private float mInitialExpandY; private float mInitialExpandX; @@ -2142,6 +2143,7 @@ public final class NotificationPanelViewController implements Dumpable { @VisibleForTesting void flingToHeight(float vel, boolean expand, float target, float collapseSpeedUpFactor, boolean expandBecauseOfFalsing) { + mLastFlingWasExpanding = expand; mHeadsUpTouchHelper.notifyFling(!expand); mKeyguardStateController.notifyPanelFlingStart(!expand /* flingingToDismiss */); setClosingWithAlphaFadeout(!expand && !isOnKeyguard() && getFadeoutAlpha() == 1.0f); @@ -2531,7 +2533,7 @@ public final class NotificationPanelViewController implements Dumpable { } // defer touches on QQS to shade while shade is collapsing. Added margin for error // as sometimes the qsExpansionFraction can be a tiny value instead of 0 when in QQS. - if (!mSplitShadeEnabled + if (!mSplitShadeEnabled && !mLastFlingWasExpanding && computeQsExpansionFraction() <= 0.01 && getExpandedFraction() < 1.0) { mShadeLog.logMotionEvent(event, "handleQsTouch: shade touched while collapsing, QS tracking disabled");