From 55a68d161bddc6dcc42557a93446daae79fec045 Mon Sep 17 00:00:00 2001 From: Chris Li Date: Fri, 23 Apr 2021 21:50:14 -0700 Subject: [PATCH] Fix EnterSplitScreenNotSupportNonResizable flaky Before, it called openQuickstep before canSplitScreen, but the later one is also calling openQuickstep. This caused the recent is pressed twice to introduce the flakness. Test: atest WMShellFlickerTests:EnterSplitScreenNotSupportNonResizable Bug: 182235458 Change-Id: Iba5af5114fd8883b73d78ac34e6f891ee8ca798f --- .../legacysplitscreen/EnterSplitScreenNotSupportNonResizable.kt | 2 -- 1 file changed, 2 deletions(-) diff --git a/libs/WindowManager/Shell/tests/flicker/src/com/android/wm/shell/flicker/legacysplitscreen/EnterSplitScreenNotSupportNonResizable.kt b/libs/WindowManager/Shell/tests/flicker/src/com/android/wm/shell/flicker/legacysplitscreen/EnterSplitScreenNotSupportNonResizable.kt index 6bc9a5c5982ce..58e92044f1b23 100644 --- a/libs/WindowManager/Shell/tests/flicker/src/com/android/wm/shell/flicker/legacysplitscreen/EnterSplitScreenNotSupportNonResizable.kt +++ b/libs/WindowManager/Shell/tests/flicker/src/com/android/wm/shell/flicker/legacysplitscreen/EnterSplitScreenNotSupportNonResizable.kt @@ -25,7 +25,6 @@ import com.android.server.wm.flicker.FlickerTestParameter import com.android.server.wm.flicker.FlickerTestParameterFactory import com.android.server.wm.flicker.dsl.FlickerBuilder import com.android.server.wm.flicker.helpers.canSplitScreen -import com.android.server.wm.flicker.helpers.openQuickstep import com.android.server.wm.traces.parser.windowmanager.WindowManagerStateHelper import com.android.wm.shell.flicker.dockedStackDividerIsInvisible import com.android.wm.shell.flicker.helpers.SplitScreenHelper @@ -64,7 +63,6 @@ class EnterSplitScreenNotSupportNonResizable( } } transitions { - device.openQuickstep(wmHelper) if (device.canSplitScreen(wmHelper)) { Assert.fail("Non-resizeable app should not enter split screen") }