From bc9ad765ec5db1293f7540c3fcf2f8a8d759bae3 Mon Sep 17 00:00:00 2001 From: Joanne Chung Date: Tue, 27 Dec 2022 15:11:13 +0000 Subject: [PATCH] Log metric when client HotwordDetectionService crashes Bug: 244387931 Test: use CTS hotword service to crash itself and check statsd_testdrive. Change-Id: Icbd10c73df268bc7ff38c986551e30e61aa95177 Merged-in: Ia6a3027eb2dc6f45d77c3025f30c43f1d93a3a2c --- .../server/voiceinteraction/HotwordDetectionConnection.java | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/services/voiceinteraction/java/com/android/server/voiceinteraction/HotwordDetectionConnection.java b/services/voiceinteraction/java/com/android/server/voiceinteraction/HotwordDetectionConnection.java index 55bf2ab3a0e9a..1c57ba572e75f 100644 --- a/services/voiceinteraction/java/com/android/server/voiceinteraction/HotwordDetectionConnection.java +++ b/services/voiceinteraction/java/com/android/server/voiceinteraction/HotwordDetectionConnection.java @@ -55,6 +55,7 @@ import static com.android.internal.util.FrameworkStatsLog.HOTWORD_DETECTOR_KEYPH import static com.android.internal.util.FrameworkStatsLog.HOTWORD_DETECTOR_KEYPHRASE_TRIGGERED__RESULT__REJECTED; import static com.android.internal.util.FrameworkStatsLog.HOTWORD_DETECTOR_KEYPHRASE_TRIGGERED__RESULT__REJECTED_FROM_RESTART; import static com.android.internal.util.FrameworkStatsLog.HOTWORD_DETECTOR_KEYPHRASE_TRIGGERED__RESULT__REJECT_UNEXPECTED_CALLBACK; +import static com.android.internal.util.FrameworkStatsLog.HOTWORD_DETECTOR_KEYPHRASE_TRIGGERED__RESULT__SERVICE_CRASH; import android.annotation.NonNull; import android.annotation.Nullable; @@ -1152,6 +1153,11 @@ final class HotwordDetectionConnection { Slog.w(TAG, "Failed to report onError status: " + e); } } + // Can improve to log exit reason if needed + HotwordMetricsLogger.writeKeyphraseTriggerEvent( + mDetectorType, + HOTWORD_DETECTOR_KEYPHRASE_TRIGGERED__RESULT__SERVICE_CRASH, + mVoiceInteractionServiceUid); } @Override