Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge change 23165 into eclair

Browse Source 
* changes:
  Fixes a race condition between entering ERROR state and initial buffer submit.
This commit is contained in:
Android (Google) Code Review
2009-08-28 13:30:51 -07:00
parent b699013a57 d06e5b877c
commit 4b027f128f
1 changed files with 10 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
media/libstagefright/OMXCodec.cpp
View File

@@ -1272,7 +1272,7 @@ void OMXCodec::fillOutputBuffers() {
} }
void OMXCodec::drainInputBuffers() { void OMXCodec::drainInputBuffers() {
CHECK_EQ(mState, EXECUTING); CHECK(mState == EXECUTING || mState == RECONFIGURING);
Vector<BufferInfo> *buffers = &mPortBuffers[kPortIndexInput]; Vector<BufferInfo> *buffers = &mPortBuffers[kPortIndexInput];
for (size_t i = 0; i < buffers->size(); ++i) { for (size_t i = 0; i < buffers->size(); ++i) {
@@ -1716,15 +1716,20 @@ status_t OMXCodec::read(
Mutex::Autolock autoLock(mLock); Mutex::Autolock autoLock(mLock);
if (mState != EXECUTING && mState != RECONFIGURING) {
return UNKNOWN_ERROR;
}
if (mInitialBufferSubmit) { if (mInitialBufferSubmit) {
mInitialBufferSubmit = false; mInitialBufferSubmit = false;
drainInputBuffers(); drainInputBuffers();
fillOutputBuffers();
}
if (mState != EXECUTING && mState != RECONFIGURING) { if (mState == EXECUTING) {
return UNKNOWN_ERROR; // Otherwise mState == RECONFIGURING and this code will trigger
// after the output port is reenabled.
fillOutputBuffers();
}
} }
int64_t seekTimeUs; int64_t seekTimeUs;