Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge "Fix a bug where we didn't call IME before calling augmented autofill" into rvc-dev

Browse Source
This commit is contained in:
Feng Cao
2020-06-17 16:50:17 +00:00
committed by Android (Google) Code Review
parent 81fa33a734 91dae475de
commit 4add155920
1 changed files with 5 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
services/autofill/java/com/android/server/autofill/Session.java
View File

@@ -3279,16 +3279,19 @@ final class Session implements RemoteFillService.FillServiceCallbacks, ViewState
}; };
// When the inline suggestion render service is available and the view is focused, there // When the inline suggestion render service is available and the view is focused, there
// are 2 cases when augmented autofill should ask IME for inline suggestion request, // are 3 cases when augmented autofill should ask IME for inline suggestion request,
// because standard autofill flow didn't: // because standard autofill flow didn't:
// 1. the field is augmented autofill only (when standard autofill provider is None or // 1. the field is augmented autofill only (when standard autofill provider is None or
// when it returns null response) // when it returns null response)
// 2. standard autofill provider doesn't support inline suggestion // 2. standard autofill provider doesn't support inline suggestion
// 3. we re-entered the autofill session and standard autofill was not re-triggered, this is
// recognized by seeing mExpiredResponse == true
final RemoteInlineSuggestionRenderService remoteRenderService = final RemoteInlineSuggestionRenderService remoteRenderService =
mService.getRemoteInlineSuggestionRenderServiceLocked(); mService.getRemoteInlineSuggestionRenderServiceLocked();
if (remoteRenderService != null if (remoteRenderService != null
&& (mForAugmentedAutofillOnly && (mForAugmentedAutofillOnly
|| !isInlineSuggestionsEnabledByAutofillProviderLocked()) || !isInlineSuggestionsEnabledByAutofillProviderLocked()
|| mExpiredResponse)
&& isViewFocusedLocked(flags)) { && isViewFocusedLocked(flags)) {
if (sDebug) Slog.d(TAG, "Create inline request for augmented autofill"); if (sDebug) Slog.d(TAG, "Create inline request for augmented autofill");
remoteRenderService.getInlineSuggestionsRendererInfo(new RemoteCallback( remoteRenderService.getInlineSuggestionsRendererInfo(new RemoteCallback(