From 4aaf8ec9dfb9a9e0f3d84e8ee95d7ac2ebca8d92 Mon Sep 17 00:00:00 2001 From: Romain Guy Date: Thu, 3 Jun 2010 10:56:41 -0700 Subject: [PATCH] Do not invoke onProgressUpdate if the task is canceled. Bug #2734382 Change-Id: I8d507ae72af2f6dfe66598fb9090872520111a6b --- core/java/android/os/AsyncTask.java | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/core/java/android/os/AsyncTask.java b/core/java/android/os/AsyncTask.java index e74697ac26da4..823134b5cab93 100644 --- a/core/java/android/os/AsyncTask.java +++ b/core/java/android/os/AsyncTask.java @@ -401,6 +401,9 @@ public abstract class AsyncTask { * publish updates on the UI thread while the background computation is * still running. Each call to this method will trigger the execution of * {@link #onProgressUpdate} on the UI thread. + * + * {@link #onProgressUpdate} will note be called if the task has been + * canceled. * * @param values The progress values to update the UI with. * @@ -408,8 +411,10 @@ public abstract class AsyncTask { * @see #doInBackground */ protected final void publishProgress(Progress... values) { - sHandler.obtainMessage(MESSAGE_POST_PROGRESS, - new AsyncTaskResult(this, values)).sendToTarget(); + if (!isCancelled()) { + sHandler.obtainMessage(MESSAGE_POST_PROGRESS, + new AsyncTaskResult(this, values)).sendToTarget(); + } } private void finish(Result result) {