From 1b0afebf370ebd89182833ab1e1b26866383838b Mon Sep 17 00:00:00 2001 From: Jason Monk Date: Thu, 3 Mar 2016 18:25:54 -0500 Subject: [PATCH] Fix night mode availability Night mode tile is getting auto-added. Do the safe thing for now and fix the checks around the tile availability to make sure it isn't shown when it shouldn't be, then fix the auto-add logic later. Bug: 27480924 Change-Id: I3d032038cbc77bf478e3c769c6796be289a8d993 --- .../android/systemui/qs/customize/TileQueryHelper.java | 6 +----- .../src/com/android/systemui/tuner/NightModeTile.java | 8 ++++++++ 2 files changed, 9 insertions(+), 5 deletions(-) diff --git a/packages/SystemUI/src/com/android/systemui/qs/customize/TileQueryHelper.java b/packages/SystemUI/src/com/android/systemui/qs/customize/TileQueryHelper.java index aa85f784fe4bc..d95d3efb058c4 100644 --- a/packages/SystemUI/src/com/android/systemui/qs/customize/TileQueryHelper.java +++ b/packages/SystemUI/src/com/android/systemui/qs/customize/TileQueryHelper.java @@ -28,8 +28,6 @@ import android.os.AsyncTask; import android.os.Handler; import android.os.Looper; import android.service.quicksettings.TileService; -import com.android.systemui.Prefs; -import com.android.systemui.Prefs.Key; import com.android.systemui.R; import com.android.systemui.qs.QSTile; import com.android.systemui.qs.QSTile.DrawableIcon; @@ -57,10 +55,8 @@ public class TileQueryHelper { } private void addSystemTiles(QSTileHost host) { - boolean hasColorMod = Prefs.getBoolean(host.getContext(), Key.QS_NIGHT_ADDED, false) - && TunerService.isTunerEnabled(host.getContext()); String possible = mContext.getString(R.string.quick_settings_tiles_default) - + ",hotspot,inversion,saver,work,cast" + (hasColorMod ? ",night" : ""); + + ",hotspot,inversion,saver,work,cast,night"; String[] possibleTiles = possible.split(","); final Handler qsHandler = new Handler(host.getLooper()); final Handler mainHandler = new Handler(Looper.getMainLooper()); diff --git a/packages/SystemUI/src/com/android/systemui/tuner/NightModeTile.java b/packages/SystemUI/src/com/android/systemui/tuner/NightModeTile.java index 61135bd968f93..26e1d46dd119d 100644 --- a/packages/SystemUI/src/com/android/systemui/tuner/NightModeTile.java +++ b/packages/SystemUI/src/com/android/systemui/tuner/NightModeTile.java @@ -20,6 +20,8 @@ import android.content.Intent; import android.provider.Settings; import com.android.internal.logging.MetricsProto.MetricsEvent; +import com.android.systemui.Prefs; +import com.android.systemui.Prefs.Key; import com.android.systemui.R; import com.android.systemui.qs.QSTile; import com.android.systemui.statusbar.policy.NightModeController; @@ -45,6 +47,12 @@ public class NightModeTile extends QSTile implements NightModeCont mNightModeController = host.getNightModeController(); } + @Override + public boolean isAvailable() { + return Prefs.getBoolean(mContext, Key.QS_NIGHT_ADDED, false) + && TunerService.isTunerEnabled(mContext); + } + @Override public void setListening(boolean listening) { if (listening) {