From 49e32af6878045957ddc9b93856a47964f20acf2 Mon Sep 17 00:00:00 2001 From: arangelov Date: Mon, 14 Oct 2019 17:54:42 +0100 Subject: [PATCH] Deprecate unused metrics PROVISIONING_TRAMPOLINE_ACTIVITY_TIME_MS PROVISIONING_POST_ENCRYPTION_ACTIVITY_TIME_MS PROVISIONING_FINALIZATION_ACTIVITY_TIME_MS These metrics are meant to measure intermediate screens, e.g. screens which finish() in onCreate. It does not make sense to measure the time they have been shown. Test: compiled Fixes: 135599174 Change-Id: I14d4f0b9fb5d70cfaeb386eb14348c0cc499113a --- .../android/stats/devicepolicy/device_policy_enums.proto | 6 +++--- proto/src/metrics_constants/metrics_constants.proto | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/core/proto/android/stats/devicepolicy/device_policy_enums.proto b/core/proto/android/stats/devicepolicy/device_policy_enums.proto index 0821d147044d0..15813a1b2a72c 100644 --- a/core/proto/android/stats/devicepolicy/device_policy_enums.proto +++ b/core/proto/android/stats/devicepolicy/device_policy_enums.proto @@ -113,9 +113,9 @@ enum EventId { PROVISIONING_PREPROVISIONING_ACTIVITY_TIME_MS = 87; PROVISIONING_ENCRYPT_DEVICE_ACTIVITY_TIME_MS = 88; PROVISIONING_WEB_ACTIVITY_TIME_MS = 89; - PROVISIONING_TRAMPOLINE_ACTIVITY_TIME_MS = 90; - PROVISIONING_POST_ENCRYPTION_ACTIVITY_TIME_MS = 91; - PROVISIONING_FINALIZATION_ACTIVITY_TIME_MS = 92; + PROVISIONING_TRAMPOLINE_ACTIVITY_TIME_MS = 90 [deprecated=true]; + PROVISIONING_POST_ENCRYPTION_ACTIVITY_TIME_MS = 91 [deprecated=true]; + PROVISIONING_FINALIZATION_ACTIVITY_TIME_MS = 92 [deprecated=true]; PROVISIONING_NETWORK_TYPE = 93; PROVISIONING_ACTION = 94; PROVISIONING_EXTRAS = 95; diff --git a/proto/src/metrics_constants/metrics_constants.proto b/proto/src/metrics_constants/metrics_constants.proto index 5b826b1c551b9..b0e401bdda8a7 100644 --- a/proto/src/metrics_constants/metrics_constants.proto +++ b/proto/src/metrics_constants/metrics_constants.proto @@ -2584,15 +2584,15 @@ message MetricsEvent { // ACTION: Logged when trampoline activity finishes. // TIME: Indicates total time taken by trampoline activity to finish in MS. - PROVISIONING_TRAMPOLINE_ACTIVITY_TIME_MS = 523; + PROVISIONING_TRAMPOLINE_ACTIVITY_TIME_MS = 523 [deprecated=true]; // ACTION: Logged when encryption activity finishes. // TIME: Indicates total time taken by post encryption activity to finish in MS. - PROVISIONING_POST_ENCRYPTION_ACTIVITY_TIME_MS = 524; + PROVISIONING_POST_ENCRYPTION_ACTIVITY_TIME_MS = 524 [deprecated=true]; // ACTION: Logged when finalization activity finishes. // TIME: Indicates time taken by finalization activity to finish in MS. - PROVISIONING_FINALIZATION_ACTIVITY_TIME_MS = 525; + PROVISIONING_FINALIZATION_ACTIVITY_TIME_MS = 525 [deprecated=true]; // OPEN: Settings Support > Phone/Chat -> Disclaimer DIALOG_SUPPORT_DISCLAIMER = 526;