From f1455b056d7641e65605167763963cdf7f1d64d5 Mon Sep 17 00:00:00 2001 From: Dave Mankoff Date: Tue, 13 Aug 2019 17:52:01 -0400 Subject: [PATCH] Allow for more wiggle room (literally) in BrightlineFalsingManager. Bug: 138812628 Change-Id: I8590b2daff0337a395d333c07c2231cc10d236a3 Test: manual testing with different people to find better values. --- .../systemui/classifier/brightline/ZigZagClassifier.java | 4 ++-- .../systemui/classifier/brightline/ZigZagClassifierTest.java | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/packages/SystemUI/src/com/android/systemui/classifier/brightline/ZigZagClassifier.java b/packages/SystemUI/src/com/android/systemui/classifier/brightline/ZigZagClassifier.java index c58b7db451b02..82ae30ac4bdf9 100644 --- a/packages/SystemUI/src/com/android/systemui/classifier/brightline/ZigZagClassifier.java +++ b/packages/SystemUI/src/com/android/systemui/classifier/brightline/ZigZagClassifier.java @@ -39,8 +39,8 @@ class ZigZagClassifier extends FalsingClassifier { // most swipes will follow somewhat of a 'C' or 'S' shape, we allow more deviance along the // `SECONDARY` axis. private static final float MAX_X_PRIMARY_DEVIANCE = .05f; - private static final float MAX_Y_PRIMARY_DEVIANCE = .05f; - private static final float MAX_X_SECONDARY_DEVIANCE = .3f; + private static final float MAX_Y_PRIMARY_DEVIANCE = .1f; + private static final float MAX_X_SECONDARY_DEVIANCE = .6f; private static final float MAX_Y_SECONDARY_DEVIANCE = .3f; private final float mMaxXPrimaryDeviance; diff --git a/packages/SystemUI/tests/src/com/android/systemui/classifier/brightline/ZigZagClassifierTest.java b/packages/SystemUI/tests/src/com/android/systemui/classifier/brightline/ZigZagClassifierTest.java index 25a1a75b0cbfe..fb4c1ec11faae 100644 --- a/packages/SystemUI/tests/src/com/android/systemui/classifier/brightline/ZigZagClassifierTest.java +++ b/packages/SystemUI/tests/src/com/android/systemui/classifier/brightline/ZigZagClassifierTest.java @@ -133,8 +133,8 @@ public class ZigZagClassifierTest extends ClassifierTest { // This test looks just like testPass_horizontalZigZagVerticalStraight but with // a shorter y range, making it look more crooked. appendMoveEvent(0, 0); - appendMoveEvent(5, 10); - appendMoveEvent(-5, 20); + appendMoveEvent(6, 10); + appendMoveEvent(-6, 20); assertThat(mClassifier.isFalseTouch(), is(true)); }