From 48e7b458694acdf3a4fc58e62437f1dbc4f29d83 Mon Sep 17 00:00:00 2001 From: Dianne Hackborn Date: Mon, 17 Jan 2011 12:28:35 -0800 Subject: [PATCH] Start renaming FragmentTransaction.openTransaction() to beginTransaction(). Change-Id: Ib4a6d824b33cca699b7b25159c491fb610d5f5da --- api/current.xml | 26 +++++++++++++++++-- core/java/android/app/DialogFragment.java | 4 +-- core/java/android/app/FragmentManager.java | 9 +++++-- core/java/android/app/LoaderManager.java | 2 +- .../preference/PreferenceActivity.java | 6 ++--- .../android/internal/app/ActionBarImpl.java | 2 +- 6 files changed, 38 insertions(+), 11 deletions(-) diff --git a/api/current.xml b/api/current.xml index ef23af2ff0006..dfc149b68eb6d 100644 --- a/api/current.xml +++ b/api/current.xml @@ -30672,6 +30672,17 @@ + + + + */ - public abstract FragmentTransaction openTransaction(); + public abstract FragmentTransaction beginTransaction(); + /** Old API */ + public FragmentTransaction openTransaction() { + return beginTransaction(); + } + /** * After a {@link FragmentTransaction} is committed with * {@link FragmentTransaction#commit FragmentTransaction.commit()}, it @@ -347,7 +352,7 @@ final class FragmentManagerImpl extends FragmentManager { }; @Override - public FragmentTransaction openTransaction() { + public FragmentTransaction beginTransaction() { return new BackStackRecord(this); } diff --git a/core/java/android/app/LoaderManager.java b/core/java/android/app/LoaderManager.java index 5f8c0984982d1..ef50bdec5ba50 100644 --- a/core/java/android/app/LoaderManager.java +++ b/core/java/android/app/LoaderManager.java @@ -60,7 +60,7 @@ public abstract class LoaderManager { * Called when a previously created loader has finished its load. Note * that normally an application is not allowed to commit fragment * transactions while in this call, since it can happen after an - * activity's state is saved. See {@link FragmentManager#openTransaction() + * activity's state is saved. See {@link FragmentManager#beginTransaction() * FragmentManager.openTransaction()} for further discussion on this. * *

This function is guaranteed to be called prior to the release of diff --git a/core/java/android/preference/PreferenceActivity.java b/core/java/android/preference/PreferenceActivity.java index 7a186f38d8826..ee3bdab3e0c25 100644 --- a/core/java/android/preference/PreferenceActivity.java +++ b/core/java/android/preference/PreferenceActivity.java @@ -1044,7 +1044,7 @@ public abstract class PreferenceActivity extends ListActivity implements getFragmentManager().popBackStack(BACK_STACK_PREFS, FragmentManager.POP_BACK_STACK_INCLUSIVE); Fragment f = Fragment.instantiate(this, fragmentName, args); - FragmentTransaction transaction = getFragmentManager().openTransaction(); + FragmentTransaction transaction = getFragmentManager().beginTransaction(); transaction.setTransition(direction == 0 ? FragmentTransaction.TRANSIT_NONE : direction > 0 ? FragmentTransaction.TRANSIT_FRAGMENT_NEXT : FragmentTransaction.TRANSIT_FRAGMENT_PREV); @@ -1136,7 +1136,7 @@ public abstract class PreferenceActivity extends ListActivity implements * the current fragment will be replaced. */ public void startPreferenceFragment(Fragment fragment, boolean push) { - FragmentTransaction transaction = getFragmentManager().openTransaction(); + FragmentTransaction transaction = getFragmentManager().beginTransaction(); transaction.replace(com.android.internal.R.id.prefs, fragment); if (push) { transaction.setTransition(FragmentTransaction.TRANSIT_FRAGMENT_OPEN); @@ -1175,7 +1175,7 @@ public abstract class PreferenceActivity extends ListActivity implements if (resultTo != null) { f.setTargetFragment(resultTo, resultRequestCode); } - FragmentTransaction transaction = getFragmentManager().openTransaction(); + FragmentTransaction transaction = getFragmentManager().beginTransaction(); transaction.replace(com.android.internal.R.id.prefs, f); if (titleRes != 0) { transaction.setBreadCrumbTitle(titleRes); diff --git a/core/java/com/android/internal/app/ActionBarImpl.java b/core/java/com/android/internal/app/ActionBarImpl.java index 4ee3083887acc..0e31feff27f56 100644 --- a/core/java/com/android/internal/app/ActionBarImpl.java +++ b/core/java/com/android/internal/app/ActionBarImpl.java @@ -492,7 +492,7 @@ public class ActionBarImpl extends ActionBar { return; } - final FragmentTransaction trans = mActivity.getFragmentManager().openTransaction() + final FragmentTransaction trans = mActivity.getFragmentManager().beginTransaction() .disallowAddToBackStack(); if (mSelectedTab == tab) {