From 4830067c551bc2023a4a788898b3fb069bacbed0 Mon Sep 17 00:00:00 2001 From: jiewenlei Date: Wed, 17 May 2023 09:47:40 -0700 Subject: [PATCH] Log selected dataset id regradless of authentication result. Authentication result is logged separately in another field. Test: m Bug: 278920289 Change-Id: Id973d69527fa4f015beffad722ad80cbabc3b028 --- .../autofill/java/com/android/server/autofill/Session.java | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/services/autofill/java/com/android/server/autofill/Session.java b/services/autofill/java/com/android/server/autofill/Session.java index 2d03daa4a5798..5d6eab77c5011 100644 --- a/services/autofill/java/com/android/server/autofill/Session.java +++ b/services/autofill/java/com/android/server/autofill/Session.java @@ -5086,13 +5086,14 @@ final class Session implements RemoteFillService.FillServiceCallbacks, ViewState + id + " destroyed"); return; } + // Selected dataset id is logged regardless of authentication result. + mPresentationStatsEventLogger.maybeSetSelectedDatasetId(datasetIndex); + mPresentationStatsEventLogger.maybeSetSelectedDatasetPickReason( + dataset.getEligibleReason()); // Autofill it directly... if (dataset.getAuthentication() == null) { if (generateEvent) { mService.logDatasetSelected(dataset.getId(), id, mClientState, uiType); - mPresentationStatsEventLogger.maybeSetSelectedDatasetId(datasetIndex); - mPresentationStatsEventLogger.maybeSetSelectedDatasetPickReason( - dataset.getEligibleReason()); } if (mCurrentViewId != null) { mInlineSessionController.hideInlineSuggestionsUiLocked(mCurrentViewId);