Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge "Add missing "try ... finally" safeguards"

Browse Source
This commit is contained in:
Treehugger Robot
2016-05-25 01:07:47 +00:00
committed by Gerrit Code Review
parent 1c3b50a00e 9a69daa706
commit 47ae606d2c
2 changed files with 29 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
core/java/android/bluetooth/BluetoothAdapter.java
View File

@@ -2029,12 +2029,15 @@ public final class BluetoothAdapter {
public void onBluetoothServiceDown() { public void onBluetoothServiceDown() {
if (VDBG) Log.d(TAG, "onBluetoothServiceDown: " + mService); if (VDBG) Log.d(TAG, "onBluetoothServiceDown: " + mService);
mServiceLock.writeLock().lock(); try {
mService = null; mServiceLock.writeLock().lock();
if (mLeScanClients != null) mLeScanClients.clear(); mService = null;
if (sBluetoothLeAdvertiser != null) sBluetoothLeAdvertiser.cleanup(); if (mLeScanClients != null) mLeScanClients.clear();
if (sBluetoothLeScanner != null) sBluetoothLeScanner.cleanup(); if (sBluetoothLeAdvertiser != null) sBluetoothLeAdvertiser.cleanup();
mServiceLock.writeLock().unlock(); if (sBluetoothLeScanner != null) sBluetoothLeScanner.cleanup();
} finally {
mServiceLock.writeLock().unlock();
}
synchronized (mProxyServiceStateCallbacks) { synchronized (mProxyServiceStateCallbacks) {
for (IBluetoothManagerCallback cb : mProxyServiceStateCallbacks ){ for (IBluetoothManagerCallback cb : mProxyServiceStateCallbacks ){

34
services/core/java/com/android/server/BluetoothManagerService.java
View File

@@ -1539,14 +1539,17 @@ class BluetoothManagerService extends IBluetoothManager.Stub {
BluetoothAdapter.STATE_OFF); BluetoothAdapter.STATE_OFF);
sendBluetoothServiceDownCallback(); sendBluetoothServiceDownCallback();
mBluetoothLock.writeLock().lock(); try {
if (mBluetooth != null) { mBluetoothLock.writeLock().lock();
mBluetooth = null; if (mBluetooth != null) {
// Unbind mBluetooth = null;
mContext.unbindService(mConnection); // Unbind
mContext.unbindService(mConnection);
}
mBluetoothGatt = null;
} finally {
mBluetoothLock.writeLock().unlock();
} }
mBluetoothGatt = null;
mBluetoothLock.writeLock().unlock();
SystemClock.sleep(100); SystemClock.sleep(100);
@@ -1851,14 +1854,17 @@ class BluetoothManagerService extends IBluetoothManager.Stub {
sendBluetoothServiceDownCallback(); sendBluetoothServiceDownCallback();
mBluetoothLock.writeLock().lock(); try {
if (mBluetooth != null) { mBluetoothLock.writeLock().lock();
mBluetooth = null; if (mBluetooth != null) {
// Unbind mBluetooth = null;
mContext.unbindService(mConnection); // Unbind
mContext.unbindService(mConnection);
}
mBluetoothGatt = null;
} finally {
mBluetoothLock.writeLock().unlock();
} }
mBluetoothGatt = null;
mBluetoothLock.writeLock().unlock();
mHandler.removeMessages(MESSAGE_BLUETOOTH_STATE_CHANGE); mHandler.removeMessages(MESSAGE_BLUETOOTH_STATE_CHANGE);
mState = BluetoothAdapter.STATE_OFF; mState = BluetoothAdapter.STATE_OFF;