From 275f323e865b020cdd76483c8c0a4c859f2085cf Mon Sep 17 00:00:00 2001 From: Etan Cohen Date: Mon, 30 Jan 2017 13:01:50 -0800 Subject: [PATCH] [AWARE] Minor hardening of manager. Callbacks are possible even if no listener was defined. Perform a check and print error (as opposed to crashing). Bug: 32315992 Test: unit-tests + integration tests passing Change-Id: Ia5eb81448ace6b88abcd448e4f378da6530ac630 --- wifi/java/android/net/wifi/aware/WifiAwareManager.java | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/wifi/java/android/net/wifi/aware/WifiAwareManager.java b/wifi/java/android/net/wifi/aware/WifiAwareManager.java index 043925edc5f02..a9e38cef97e89 100644 --- a/wifi/java/android/net/wifi/aware/WifiAwareManager.java +++ b/wifi/java/android/net/wifi/aware/WifiAwareManager.java @@ -706,7 +706,11 @@ public class WifiAwareManager { attachCallback.onAttachFailed(); break; case CALLBACK_IDENTITY_CHANGED: - identityChangedListener.onIdentityChanged((byte[]) msg.obj); + if (identityChangedListener == null) { + Log.e(TAG, "CALLBACK_IDENTITY_CHANGED: null listener."); + } else { + identityChangedListener.onIdentityChanged((byte[]) msg.obj); + } break; case CALLBACK_RANGING_SUCCESS: { RttManager.RttListener listener = getAndRemoveRangingListener(msg.arg1);