From 46da9999d89fa22b3e3e1b761b5978605053ca0d Mon Sep 17 00:00:00 2001 From: Caitlin Shkuratov Date: Tue, 7 Mar 2023 15:43:02 +0000 Subject: [PATCH] [Table logging] Add tracing to the log methods. Bug: 272016422 Test: Take systrace -> toggle wifi on and off multiple times -> see logs in systrace (systrace attached to bug) Change-Id: I57fbba0acbd4cc15d823e1043e5b94cfe6fb016d --- .../src/com/android/systemui/log/table/TableLogBuffer.kt | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/packages/SystemUI/src/com/android/systemui/log/table/TableLogBuffer.kt b/packages/SystemUI/src/com/android/systemui/log/table/TableLogBuffer.kt index 29f273a5ed41b..8f950ee7271f2 100644 --- a/packages/SystemUI/src/com/android/systemui/log/table/TableLogBuffer.kt +++ b/packages/SystemUI/src/com/android/systemui/log/table/TableLogBuffer.kt @@ -16,13 +16,13 @@ package com.android.systemui.log.table +import android.os.Trace import com.android.systemui.Dumpable import com.android.systemui.plugins.util.RingBuffer import com.android.systemui.util.time.SystemClock import java.io.PrintWriter import java.text.SimpleDateFormat import java.util.Locale -import kotlinx.coroutines.flow.Flow /** * A logger that logs changes in table format. @@ -138,18 +138,24 @@ class TableLogBuffer( // timestamps.) private fun logChange(timestamp: Long, prefix: String, columnName: String, value: String?) { + Trace.beginSection("TableLogBuffer#logChange(string)") val change = obtain(timestamp, prefix, columnName) change.set(value) + Trace.endSection() } private fun logChange(timestamp: Long, prefix: String, columnName: String, value: Boolean) { + Trace.beginSection("TableLogBuffer#logChange(boolean)") val change = obtain(timestamp, prefix, columnName) change.set(value) + Trace.endSection() } private fun logChange(timestamp: Long, prefix: String, columnName: String, value: Int?) { + Trace.beginSection("TableLogBuffer#logChange(int)") val change = obtain(timestamp, prefix, columnName) change.set(value) + Trace.endSection() } // TODO(b/259454430): Add additional change types here.