From 46466b9600b3426aa5ac375651e5a2d1949a6910 Mon Sep 17 00:00:00 2001 From: shaoweishen Date: Mon, 22 Nov 2021 09:08:03 +0000 Subject: [PATCH] [Output Switcher] Cancel setting color filter for device icon Since the device icon color need to be updated based on Device's status, set color filter for the icon in MediaOutputController, which manages the colors. Bug: 203072942 Test: test on device Change-Id: I8e0b5a9a5d83306ab3fbbffbafd0a5179cc8a67b --- .../settingslib/media/BluetoothMediaDevice.java | 8 +------- .../settingslib/media/InfoMediaDevice.java | 4 +--- .../android/settingslib/media/MediaDevice.java | 15 +-------------- .../settingslib/media/PhoneMediaDevice.java | 4 +--- 4 files changed, 4 insertions(+), 27 deletions(-) diff --git a/packages/SettingsLib/src/com/android/settingslib/media/BluetoothMediaDevice.java b/packages/SettingsLib/src/com/android/settingslib/media/BluetoothMediaDevice.java index cd5c78d19c8cf..360361ba0104d 100644 --- a/packages/SettingsLib/src/com/android/settingslib/media/BluetoothMediaDevice.java +++ b/packages/SettingsLib/src/com/android/settingslib/media/BluetoothMediaDevice.java @@ -18,7 +18,6 @@ package com.android.settingslib.media; import android.bluetooth.BluetoothClass; import android.bluetooth.BluetoothDevice; import android.content.Context; -import android.graphics.drawable.BitmapDrawable; import android.graphics.drawable.Drawable; import android.media.MediaRoute2Info; import android.media.MediaRouter2Manager; @@ -57,12 +56,7 @@ public class BluetoothMediaDevice extends MediaDevice { @Override public Drawable getIcon() { - final Drawable drawable = - BluetoothUtils.getBtDrawableWithDescription(mContext, mCachedDevice).first; - if (!(drawable instanceof BitmapDrawable)) { - setColorFilter(drawable); - } - return drawable; + return BluetoothUtils.getBtDrawableWithDescription(mContext, mCachedDevice).first; } @Override diff --git a/packages/SettingsLib/src/com/android/settingslib/media/InfoMediaDevice.java b/packages/SettingsLib/src/com/android/settingslib/media/InfoMediaDevice.java index c34f65cfdbf6c..1b5ce8fee5c3b 100644 --- a/packages/SettingsLib/src/com/android/settingslib/media/InfoMediaDevice.java +++ b/packages/SettingsLib/src/com/android/settingslib/media/InfoMediaDevice.java @@ -58,9 +58,7 @@ public class InfoMediaDevice extends MediaDevice { @Override public Drawable getIcon() { - final Drawable drawable = getIconWithoutBackground(); - setColorFilter(drawable); - return drawable; + return getIconWithoutBackground(); } @Override diff --git a/packages/SettingsLib/src/com/android/settingslib/media/MediaDevice.java b/packages/SettingsLib/src/com/android/settingslib/media/MediaDevice.java index a49d7f60a4799..970abff3054b9 100644 --- a/packages/SettingsLib/src/com/android/settingslib/media/MediaDevice.java +++ b/packages/SettingsLib/src/com/android/settingslib/media/MediaDevice.java @@ -15,6 +15,7 @@ */ package com.android.settingslib.media; +import static android.media.MediaRoute2Info.TYPE_BLE_HEADSET; import static android.media.MediaRoute2Info.TYPE_BLUETOOTH_A2DP; import static android.media.MediaRoute2Info.TYPE_BUILTIN_SPEAKER; import static android.media.MediaRoute2Info.TYPE_DOCK; @@ -29,12 +30,8 @@ import static android.media.MediaRoute2Info.TYPE_USB_DEVICE; import static android.media.MediaRoute2Info.TYPE_USB_HEADSET; import static android.media.MediaRoute2Info.TYPE_WIRED_HEADPHONES; import static android.media.MediaRoute2Info.TYPE_WIRED_HEADSET; -import static android.media.MediaRoute2Info.TYPE_BLE_HEADSET; import android.content.Context; -import android.content.res.ColorStateList; -import android.graphics.PorterDuff; -import android.graphics.PorterDuffColorFilter; import android.graphics.drawable.Drawable; import android.media.MediaRoute2Info; import android.media.MediaRouter2Manager; @@ -44,8 +41,6 @@ import android.util.Log; import androidx.annotation.IntDef; import androidx.annotation.VisibleForTesting; -import com.android.settingslib.R; - import java.lang.annotation.Retention; import java.lang.annotation.RetentionPolicy; import java.util.ArrayList; @@ -141,14 +136,6 @@ public abstract class MediaDevice implements Comparable { getId()); } - void setColorFilter(Drawable drawable) { - final ColorStateList list = - mContext.getResources().getColorStateList( - R.color.advanced_icon_color, mContext.getTheme()); - drawable.setColorFilter(new PorterDuffColorFilter(list.getDefaultColor(), - PorterDuff.Mode.SRC_IN)); - } - /** * Get name from MediaDevice. * diff --git a/packages/SettingsLib/src/com/android/settingslib/media/PhoneMediaDevice.java b/packages/SettingsLib/src/com/android/settingslib/media/PhoneMediaDevice.java index 1139d33d440dc..c16ecb5587125 100644 --- a/packages/SettingsLib/src/com/android/settingslib/media/PhoneMediaDevice.java +++ b/packages/SettingsLib/src/com/android/settingslib/media/PhoneMediaDevice.java @@ -84,9 +84,7 @@ public class PhoneMediaDevice extends MediaDevice { @Override public Drawable getIcon() { - final Drawable drawable = getIconWithoutBackground(); - setColorFilter(drawable); - return drawable; + return getIconWithoutBackground(); } @Override