Merge "Quick fix for possible deadlock in LMS" into rvc-dev

This commit is contained in:
TreeHugger Robot
2020-03-03 02:59:15 +00:00
committed by Android (Google) Code Review

View File

@@ -2562,22 +2562,28 @@ public class LocationManager {
mRemoteCancellationSignal = remoteCancellationSignal;
}
public synchronized void cancel() {
mExecutor = null;
mConsumer = null;
public void cancel() {
ICancellationSignal cancellationSignal;
synchronized (this) {
mExecutor = null;
mConsumer = null;
if (mAlarmManager != null) {
mAlarmManager.cancel(this);
mAlarmManager = null;
if (mAlarmManager != null) {
mAlarmManager.cancel(this);
mAlarmManager = null;
}
// ensure only one cancel event will go through
cancellationSignal = mRemoteCancellationSignal;
mRemoteCancellationSignal = null;
}
if (mRemoteCancellationSignal != null) {
if (cancellationSignal != null) {
try {
mRemoteCancellationSignal.cancel();
cancellationSignal.cancel();
} catch (RemoteException e) {
// ignore
}
mRemoteCancellationSignal = null;
}
}