Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Don't invalidate list data during layout.

Browse Source 
When a FastScroller is enabled, we were invalidating the
list data during layout, which left the UI in a bad state.
Long-presses didn't work properly, and TalkBack touches
were impossible to perform.

Bug: 31160338

Test: Manually tested long pressing, and verified
that TalkBack now works with the TestActivity in ag/1567328.
Change-Id: Iecd2d597259748a3ecbf5573950e565a0e9faa42
This commit is contained in:
Phil Weaver
2016-11-01 09:55:24 -07:00
parent bbae4e6ce6
commit 456158ffc2
1 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
core/java/android/widget/AbsListView.java
View File

@@ -2160,7 +2160,6 @@ public abstract class AbsListView extends AdapterView<ListAdapter> implements Te
} }
layoutChildren(); layoutChildren();
mInLayout = false;
mOverscrollMax = (b - t) / OVERSCROLL_LIMIT_DIVISOR; mOverscrollMax = (b - t) / OVERSCROLL_LIMIT_DIVISOR;
@@ -2168,6 +2167,7 @@ public abstract class AbsListView extends AdapterView<ListAdapter> implements Te
if (mFastScroll != null) { if (mFastScroll != null) {
mFastScroll.onItemCountChanged(getChildCount(), mItemCount); mFastScroll.onItemCountChanged(getChildCount(), mItemCount);
} }
mInLayout = false;
} }
/** /**
@@ -2697,6 +2697,9 @@ public abstract class AbsListView extends AdapterView<ListAdapter> implements Te
* fail to relayout them properly to accommodate for new bounds. * fail to relayout them properly to accommodate for new bounds.
*/ */
void handleBoundsChange() { void handleBoundsChange() {
if (mInLayout) {
return;
}
final int childCount = getChildCount(); final int childCount = getChildCount();
if (childCount > 0) { if (childCount > 0) {
mDataChanged = true; mDataChanged = true;