From 78dbccadd33c740a927110e522a147b869ec7c8d Mon Sep 17 00:00:00 2001 From: Massimo Carli Date: Sat, 3 Dec 2022 17:29:38 +0000 Subject: [PATCH] Log letterbox persistent positioning Adds additional information to the dump for Letterboxing Fixes: 261224023 Test: Run `adb shell wm get-letterbox-style` and check the current letterbox positioning Change-Id: Id215b4819533a7e5adbe16696fe0cddfcb1b02f9 --- .../java/com/android/server/wm/LetterboxUiController.java | 6 ++++++ .../com/android/server/wm/WindowManagerShellCommand.java | 6 ++++++ 2 files changed, 12 insertions(+) diff --git a/services/core/java/com/android/server/wm/LetterboxUiController.java b/services/core/java/com/android/server/wm/LetterboxUiController.java index 6edb63c14c648..76ee733cbb279 100644 --- a/services/core/java/com/android/server/wm/LetterboxUiController.java +++ b/services/core/java/com/android/server/wm/LetterboxUiController.java @@ -674,6 +674,12 @@ final class LetterboxUiController { + getHorizontalPositionMultiplier(mActivityRecord.getParent().getConfiguration())); pw.println(prefix + " letterboxVerticalPositionMultiplier=" + getVerticalPositionMultiplier(mActivityRecord.getParent().getConfiguration())); + pw.println(prefix + " letterboxPositionForHorizontalReachability=" + + LetterboxConfiguration.letterboxHorizontalReachabilityPositionToString( + mLetterboxConfiguration.getLetterboxPositionForHorizontalReachability())); + pw.println(prefix + " letterboxPositionForVerticalReachability=" + + LetterboxConfiguration.letterboxVerticalReachabilityPositionToString( + mLetterboxConfiguration.getLetterboxPositionForVerticalReachability())); pw.println(prefix + " fixedOrientationLetterboxAspectRatio=" + mLetterboxConfiguration.getFixedOrientationLetterboxAspectRatio()); pw.println(prefix + " defaultMinAspectRatioForUnresizableApps=" diff --git a/services/core/java/com/android/server/wm/WindowManagerShellCommand.java b/services/core/java/com/android/server/wm/WindowManagerShellCommand.java index c22091b4eacb0..b8cf0ad2e774a 100644 --- a/services/core/java/com/android/server/wm/WindowManagerShellCommand.java +++ b/services/core/java/com/android/server/wm/WindowManagerShellCommand.java @@ -1206,6 +1206,12 @@ public class WindowManagerShellCommand extends ShellCommand { pw.println("Default position for vertical reachability: " + LetterboxConfiguration.letterboxVerticalReachabilityPositionToString( mLetterboxConfiguration.getDefaultPositionForVerticalReachability())); + pw.println("Current position for horizontal reachability:" + + LetterboxConfiguration.letterboxHorizontalReachabilityPositionToString( + mLetterboxConfiguration.getLetterboxPositionForHorizontalReachability())); + pw.println("Current position for vertical reachability:" + + LetterboxConfiguration.letterboxVerticalReachabilityPositionToString( + mLetterboxConfiguration.getLetterboxPositionForVerticalReachability())); pw.println("Is education enabled: " + mLetterboxConfiguration.getIsEducationEnabled()); pw.println("Is using split screen aspect ratio as aspect ratio for unresizable apps: "