From 4503cf67b57a2a75e86ce4e36ccb69249048c996 Mon Sep 17 00:00:00 2001 From: Kenny Root Date: Thu, 14 Jun 2012 13:05:18 -0700 Subject: [PATCH] Make lib dir before changing ownership of app dir Bug: 6668897 Change-Id: I8998a50359892277b15e80b5b5590ff94b125467 --- cmds/installd/commands.c | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/cmds/installd/commands.c b/cmds/installd/commands.c index 0bc737185b917..96a6438768c4b 100644 --- a/cmds/installd/commands.c +++ b/cmds/installd/commands.c @@ -53,11 +53,7 @@ int install(const char *pkgname, uid_t uid, gid_t gid) unlink(pkgdir); return -errno; } - if (chown(pkgdir, uid, gid) < 0) { - ALOGE("cannot chown dir '%s': %s\n", pkgdir, strerror(errno)); - unlink(pkgdir); - return -errno; - } + if (mkdir(libdir, 0755) < 0) { ALOGE("cannot create dir '%s': %s\n", libdir, strerror(errno)); unlink(pkgdir); @@ -75,6 +71,13 @@ int install(const char *pkgname, uid_t uid, gid_t gid) unlink(pkgdir); return -errno; } + + if (chown(pkgdir, uid, gid) < 0) { + ALOGE("cannot chown dir '%s': %s\n", pkgdir, strerror(errno)); + unlink(libdir); + unlink(pkgdir); + return -errno; + } return 0; }