From 45f533c1addf3de344ae4508f64ff1037791894f Mon Sep 17 00:00:00 2001 From: Andrew Scull Date: Fri, 19 May 2017 15:37:20 +0100 Subject: [PATCH] NetworkManagementService.java: fix error-prone warnings - Lock objects should be final - Inner classes should be static if possible Change-Id: Idca268e03ea1e9f80e64012d1e011dc8bca1d9a8 Merged-In: Idca268e03ea1e9f80e64012d1e011dc8bca1d9a8 Fix: 38446237 Test: Build --- .../java/com/android/server/NetworkManagementService.java | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/services/core/java/com/android/server/NetworkManagementService.java b/services/core/java/com/android/server/NetworkManagementService.java index 7e1a1ca60826e..ac2f4d09a5bae 100644 --- a/services/core/java/com/android/server/NetworkManagementService.java +++ b/services/core/java/com/android/server/NetworkManagementService.java @@ -149,7 +149,7 @@ public class NetworkManagementService extends INetworkManagementService.Stub */ public static final String PERMISSION_SYSTEM = "SYSTEM"; - class NetdResponseCode { + static class NetdResponseCode { /* Keep in sync with system/netd/server/ResponseCode.h */ public static final int InterfaceListResult = 110; public static final int TetherInterfaceListResult = 111; @@ -220,7 +220,7 @@ public class NetworkManagementService extends INetworkManagementService.Stub private final NetworkStatsFactory mStatsFactory = new NetworkStatsFactory(); - private Object mQuotaLock = new Object(); + private final Object mQuotaLock = new Object(); /** Set of interfaces with active quotas. */ @GuardedBy("mQuotaLock") @@ -265,7 +265,7 @@ public class NetworkManagementService extends INetworkManagementService.Stub @GuardedBy("mQuotaLock") private boolean mDataSaverMode; - private Object mIdleTimerLock = new Object(); + private final Object mIdleTimerLock = new Object(); /** Set of interfaces with active idle timers. */ private static class IdleTimerParams { public final int timeout;