Merge "Remove ExpandableNotificationRow#getExtraBottomPadding()" into tm-qpr-dev

This commit is contained in:
András Kurucz
2023-03-14 10:10:28 +00:00
committed by Android (Google) Code Review
3 changed files with 2 additions and 18 deletions

View File

@@ -191,7 +191,6 @@ public class ExpandableNotificationRow extends ActivatableNotificationView
private int mMaxSmallHeight; private int mMaxSmallHeight;
private int mMaxSmallHeightLarge; private int mMaxSmallHeightLarge;
private int mMaxExpandedHeight; private int mMaxExpandedHeight;
private int mIncreasedPaddingBetweenElements;
private int mNotificationLaunchHeight; private int mNotificationLaunchHeight;
private boolean mMustStayOnScreen; private boolean mMustStayOnScreen;
@@ -3109,14 +3108,6 @@ public class ExpandableNotificationRow extends ActivatableNotificationView
return showingLayout != null && showingLayout.requireRowToHaveOverlappingRendering(); return showingLayout != null && showingLayout.requireRowToHaveOverlappingRendering();
} }
@Override
public int getExtraBottomPadding() {
if (mIsSummaryWithChildren && isGroupExpanded()) {
return mIncreasedPaddingBetweenElements;
}
return 0;
}
public void setInlineReplyAnimationFlagEnabled(boolean isEnabled) { public void setInlineReplyAnimationFlagEnabled(boolean isEnabled) {
mIsInlineReplyAnimationFlagEnabled = isEnabled; mIsInlineReplyAnimationFlagEnabled = isEnabled;
} }

View File

@@ -451,7 +451,7 @@ public abstract class ExpandableView extends FrameLayout implements Dumpable, Ro
protected void updateClipping() { protected void updateClipping() {
if (mClipToActualHeight && shouldClipToActualHeight()) { if (mClipToActualHeight && shouldClipToActualHeight()) {
int top = getClipTopAmount(); int top = getClipTopAmount();
int bottom = Math.max(Math.max(getActualHeight() + getExtraBottomPadding() int bottom = Math.max(Math.max(getActualHeight()
- mClipBottomAmount, top), mMinimumHeightForClipping); - mClipBottomAmount, top), mMinimumHeightForClipping);
mClipRect.set(Integer.MIN_VALUE, top, Integer.MAX_VALUE, bottom); mClipRect.set(Integer.MIN_VALUE, top, Integer.MAX_VALUE, bottom);
setClipBounds(mClipRect); setClipBounds(mClipRect);
@@ -591,13 +591,6 @@ public abstract class ExpandableView extends FrameLayout implements Dumpable, Ro
return mTransientContainer; return mTransientContainer;
} }
/**
* @return padding used to alter how much of the view is clipped.
*/
public int getExtraBottomPadding() {
return 0;
}
/** /**
* @return true if the group's expansion state is changing, false otherwise. * @return true if the group's expansion state is changing, false otherwise.
*/ */

View File

@@ -4499,7 +4499,7 @@ public class NotificationStackScrollLayout extends ViewGroup implements Dumpable
expandableView.setFakeShadowIntensity(0.0f, 0.0f, 0, 0); expandableView.setFakeShadowIntensity(0.0f, 0.0f, 0, 0);
} else { } else {
float yLocation = previous.getTranslationY() + previous.getActualHeight() - float yLocation = previous.getTranslationY() + previous.getActualHeight() -
expandableView.getTranslationY() - previous.getExtraBottomPadding(); expandableView.getTranslationY();
expandableView.setFakeShadowIntensity( expandableView.setFakeShadowIntensity(
diff / FakeShadowView.SHADOW_SIBLING_TRESHOLD, diff / FakeShadowView.SHADOW_SIBLING_TRESHOLD,
previous.getOutlineAlpha(), (int) yLocation, previous.getOutlineAlpha(), (int) yLocation,