From c292eff31f6b99a7d48caa1efb49800080d641d3 Mon Sep 17 00:00:00 2001 From: Fabian Kozynski Date: Thu, 10 Feb 2022 13:38:24 -0500 Subject: [PATCH] Remove QSDetail Also remove related classes, calls, and resources that were used by QSDetail and are no longer needed. Test: atest SystemUITests Test: TileService cts tests Test: adb shell cmd statusbar expand-settings Fixes: 198796184 Change-Id: Ib5c54f197d03794aca35d0305e3e62c7daedb23a --- .../systemui/plugins/qs/DetailAdapter.java | 103 -- .../android/systemui/plugins/qs/QSTile.java | 11 +- .../color-night/qs_detail_progress_track.xml | 20 - .../res/color/qs_detail_progress_track.xml | 20 - .../res/drawable/qs_detail_background.xml | 33 - packages/SystemUI/res/layout/qs_detail.xml | 62 - .../SystemUI/res/layout/qs_detail_buttons.xml | 44 - .../SystemUI/res/layout/qs_detail_header.xml | 65 - .../SystemUI/res/layout/qs_detail_item.xml | 70 -- .../SystemUI/res/layout/qs_detail_items.xml | 55 - .../SystemUI/res/layout/qs_detail_switch.xml | 23 - packages/SystemUI/res/layout/qs_panel.xml | 4 - .../res/layout/qs_user_detail_item.xml | 2 +- .../res/layout/tuner_zen_mode_panel.xml | 48 - .../SystemUI/res/layout/zen_mode_panel.xml | 170 --- packages/SystemUI/res/values-land/dimens.xml | 5 - .../SystemUI/res/values-sw410dp/dimens.xml | 2 - .../SystemUI/res/values-sw600dp/dimens.xml | 3 - packages/SystemUI/res/values/attrs.xml | 7 - packages/SystemUI/res/values/dimens.xml | 25 +- packages/SystemUI/res/values/strings.xml | 10 - packages/SystemUI/res/values/styles.xml | 31 +- .../src/com/android/systemui/flags/Flags.java | 4 + .../android/systemui/qs/AutoSizingList.java | 132 -- .../android/systemui/qs/QSContainerImpl.java | 5 - .../src/com/android/systemui/qs/QSDetail.java | 439 ------- .../android/systemui/qs/QSDetailClipper.java | 2 +- .../systemui/qs/QSDetailDisplayer.java | 48 - .../android/systemui/qs/QSDetailItems.java | 289 ----- .../src/com/android/systemui/qs/QSEvents.kt | 6 +- .../com/android/systemui/qs/QSFragment.java | 33 +- .../src/com/android/systemui/qs/QSPanel.java | 137 +-- .../systemui/qs/QSPanelController.java | 35 +- .../systemui/qs/QSPanelControllerBase.java | 15 +- .../systemui/qs/QuickStatusBarHeader.java | 5 - .../qs/customize/TileQueryHelper.java | 9 - .../systemui/qs/tileimpl/QSFactoryImpl.java | 6 - .../systemui/qs/tileimpl/QSTileImpl.java | 72 +- .../systemui/qs/tiles/BluetoothTile.java | 180 --- .../android/systemui/qs/tiles/CastTile.java | 148 +-- .../systemui/qs/tiles/CellularTile.java | 71 +- .../android/systemui/qs/tiles/DndTile.java | 185 +-- .../systemui/qs/tiles/InternetTile.java | 4 - .../qs/tiles/SensorPrivacyToggleTile.java | 7 - .../systemui/qs/tiles/UserDetailItemView.java | 2 +- .../android/systemui/qs/tiles/UserTile.java | 127 -- .../android/systemui/qs/tiles/WifiTile.java | 178 --- .../qs/user/UserSwitchDialogController.kt | 13 +- .../phone/MultiUserSwitchController.java | 27 +- .../NotificationPanelViewController.java | 18 - .../phone/StatusBarCommandQueueCallbacks.java | 5 - .../KeyguardQsUserSwitchController.java | 54 +- .../policy/UserSwitcherController.java | 79 -- .../systemui/tuner/TunerZenModePanel.java | 147 --- .../volume/VolumeDialogComponent.java | 10 +- .../android/systemui/volume/ZenModePanel.java | 1077 ----------------- .../com/android/systemui/qs/QSDetailTest.java | 203 ---- .../android/systemui/qs/QSFragmentTest.java | 2 - .../systemui/qs/QSPanelControllerTest.java | 151 --- .../com/android/systemui/qs/QSPanelTest.kt | 25 - .../qs/customize/TileQueryHelperTest.java | 7 - .../systemui/qs/tileimpl/QSFactoryImplTest.kt | 4 - .../qs/user/UserSwitchDialogControllerTest.kt | 15 +- .../shared/plugins/VersionInfoTest.java | 2 - .../NotificationPanelViewControllerTest.java | 4 - .../KeyguardQsUserSwitchControllerTest.kt | 19 +- .../policy/UserSwitcherControllerTest.kt | 4 +- 67 files changed, 79 insertions(+), 4739 deletions(-) delete mode 100644 packages/SystemUI/plugin/src/com/android/systemui/plugins/qs/DetailAdapter.java delete mode 100644 packages/SystemUI/res/color-night/qs_detail_progress_track.xml delete mode 100644 packages/SystemUI/res/color/qs_detail_progress_track.xml delete mode 100644 packages/SystemUI/res/drawable/qs_detail_background.xml delete mode 100644 packages/SystemUI/res/layout/qs_detail.xml delete mode 100644 packages/SystemUI/res/layout/qs_detail_buttons.xml delete mode 100644 packages/SystemUI/res/layout/qs_detail_header.xml delete mode 100644 packages/SystemUI/res/layout/qs_detail_item.xml delete mode 100644 packages/SystemUI/res/layout/qs_detail_items.xml delete mode 100644 packages/SystemUI/res/layout/qs_detail_switch.xml delete mode 100644 packages/SystemUI/res/layout/tuner_zen_mode_panel.xml delete mode 100644 packages/SystemUI/res/layout/zen_mode_panel.xml delete mode 100644 packages/SystemUI/src/com/android/systemui/qs/AutoSizingList.java delete mode 100644 packages/SystemUI/src/com/android/systemui/qs/QSDetail.java delete mode 100644 packages/SystemUI/src/com/android/systemui/qs/QSDetailDisplayer.java delete mode 100644 packages/SystemUI/src/com/android/systemui/qs/QSDetailItems.java delete mode 100644 packages/SystemUI/src/com/android/systemui/qs/tiles/UserTile.java delete mode 100644 packages/SystemUI/src/com/android/systemui/tuner/TunerZenModePanel.java delete mode 100644 packages/SystemUI/tests/src/com/android/systemui/qs/QSDetailTest.java delete mode 100644 packages/SystemUI/tests/src/com/android/systemui/qs/QSPanelControllerTest.java diff --git a/packages/SystemUI/plugin/src/com/android/systemui/plugins/qs/DetailAdapter.java b/packages/SystemUI/plugin/src/com/android/systemui/plugins/qs/DetailAdapter.java deleted file mode 100644 index 6d1408d5d2124..0000000000000 --- a/packages/SystemUI/plugin/src/com/android/systemui/plugins/qs/DetailAdapter.java +++ /dev/null @@ -1,103 +0,0 @@ -/* - * Copyright (C) 2017 The Android Open Source Project - * - * Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file - * except in compliance with the License. You may obtain a copy of the License at - * - * http://www.apache.org/licenses/LICENSE-2.0 - * - * Unless required by applicable law or agreed to in writing, software distributed under the - * License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY - * KIND, either express or implied. See the License for the specific language governing - * permissions and limitations under the License. - */ - -package com.android.systemui.plugins.qs; - -import android.content.Context; -import android.content.Intent; -import android.content.res.Resources; -import android.view.View; -import android.view.ViewGroup; - -import com.android.internal.logging.UiEventLogger; -import com.android.systemui.plugins.annotations.ProvidesInterface; - -@ProvidesInterface(version = DetailAdapter.VERSION) -public interface DetailAdapter { - public static final int VERSION = 1; - - CharSequence getTitle(); - Boolean getToggleState(); - - default boolean getToggleEnabled() { - return true; - } - - View createDetailView(Context context, View convertView, ViewGroup parent); - - /** - * @return intent for opening more settings related to this detail panel. If null, the more - * settings button will not be shown - */ - Intent getSettingsIntent(); - - /** - * @return resource id of the string to use for opening the settings intent. If - * {@code Resources.ID_NULL}, then use the default string: - * {@code com.android.systemui.R.string.quick_settings_more_settings} - */ - default int getSettingsText() { - return Resources.ID_NULL; - } - - /** - * @return resource id of the string to use for closing the detail panel. If - * {@code Resources.ID_NULL}, then use the default string: - * {@code com.android.systemui.R.string.quick_settings_done} - */ - default int getDoneText() { - return Resources.ID_NULL; - } - - void setToggleState(boolean state); - int getMetricsCategory(); - - /** - * Indicates whether the detail view wants to have its header (back button, title and - * toggle) shown. - */ - default boolean hasHeader() { - return true; - } - - /** - * Indicates whether the detail view wants to animate when shown. This has no affect over the - * closing animation. Detail panels will always animate when closed. - */ - default boolean shouldAnimate() { - return true; - } - - /** - * @return true if the callback handled the event and wants to keep the detail panel open, false - * otherwise. Returning false will close the panel. - */ - default boolean onDoneButtonClicked() { - return false; - } - - default UiEventLogger.UiEventEnum openDetailEvent() { - return INVALID; - } - - default UiEventLogger.UiEventEnum closeDetailEvent() { - return INVALID; - } - - default UiEventLogger.UiEventEnum moreSettingsEvent() { - return INVALID; - } - - UiEventLogger.UiEventEnum INVALID = () -> 0; -} diff --git a/packages/SystemUI/plugin/src/com/android/systemui/plugins/qs/QSTile.java b/packages/SystemUI/plugin/src/com/android/systemui/plugins/qs/QSTile.java index 1ef5324077614..669d6a3835ac5 100644 --- a/packages/SystemUI/plugin/src/com/android/systemui/plugins/qs/QSTile.java +++ b/packages/SystemUI/plugin/src/com/android/systemui/plugins/qs/QSTile.java @@ -35,14 +35,12 @@ import java.util.function.Supplier; @ProvidesInterface(version = QSTile.VERSION) @DependsOn(target = QSIconView.class) -@DependsOn(target = DetailAdapter.class) @DependsOn(target = Callback.class) @DependsOn(target = Icon.class) @DependsOn(target = State.class) public interface QSTile { - int VERSION = 2; + int VERSION = 3; - DetailAdapter getDetailAdapter(); String getTileSpec(); boolean isAvailable(); @@ -117,12 +115,9 @@ public interface QSTile { } @ProvidesInterface(version = Callback.VERSION) - public interface Callback { - public static final int VERSION = 1; + interface Callback { + static final int VERSION = 2; void onStateChanged(State state); - void onShowDetail(boolean show); - void onToggleStateChanged(boolean state); - void onScanStateChanged(boolean state); } @ProvidesInterface(version = Icon.VERSION) diff --git a/packages/SystemUI/res/color-night/qs_detail_progress_track.xml b/packages/SystemUI/res/color-night/qs_detail_progress_track.xml deleted file mode 100644 index c56382e6047f6..0000000000000 --- a/packages/SystemUI/res/color-night/qs_detail_progress_track.xml +++ /dev/null @@ -1,20 +0,0 @@ - - - - - - diff --git a/packages/SystemUI/res/color/qs_detail_progress_track.xml b/packages/SystemUI/res/color/qs_detail_progress_track.xml deleted file mode 100644 index d86119fc01fef..0000000000000 --- a/packages/SystemUI/res/color/qs_detail_progress_track.xml +++ /dev/null @@ -1,20 +0,0 @@ - - - - - - diff --git a/packages/SystemUI/res/drawable/qs_detail_background.xml b/packages/SystemUI/res/drawable/qs_detail_background.xml deleted file mode 100644 index c23649d629bde..0000000000000 --- a/packages/SystemUI/res/drawable/qs_detail_background.xml +++ /dev/null @@ -1,33 +0,0 @@ - - - - - - - - - - - - - - - - - - - \ No newline at end of file diff --git a/packages/SystemUI/res/layout/qs_detail.xml b/packages/SystemUI/res/layout/qs_detail.xml deleted file mode 100644 index 78655c03dd73b..0000000000000 --- a/packages/SystemUI/res/layout/qs_detail.xml +++ /dev/null @@ -1,62 +0,0 @@ - - - - - - - - - - - - - - - - - diff --git a/packages/SystemUI/res/layout/qs_detail_buttons.xml b/packages/SystemUI/res/layout/qs_detail_buttons.xml deleted file mode 100644 index 75f43f9a58086..0000000000000 --- a/packages/SystemUI/res/layout/qs_detail_buttons.xml +++ /dev/null @@ -1,44 +0,0 @@ - - - - - - - - - diff --git a/packages/SystemUI/res/layout/qs_detail_header.xml b/packages/SystemUI/res/layout/qs_detail_header.xml deleted file mode 100644 index d1ab054dd335d..0000000000000 --- a/packages/SystemUI/res/layout/qs_detail_header.xml +++ /dev/null @@ -1,65 +0,0 @@ - - - - - - - - - - - - - - - - - diff --git a/packages/SystemUI/res/layout/qs_detail_item.xml b/packages/SystemUI/res/layout/qs_detail_item.xml deleted file mode 100644 index 0844bb46d53f1..0000000000000 --- a/packages/SystemUI/res/layout/qs_detail_item.xml +++ /dev/null @@ -1,70 +0,0 @@ - - - - - - - - - - - - - - - - diff --git a/packages/SystemUI/res/layout/qs_detail_items.xml b/packages/SystemUI/res/layout/qs_detail_items.xml deleted file mode 100644 index 60cba67cf3d73..0000000000000 --- a/packages/SystemUI/res/layout/qs_detail_items.xml +++ /dev/null @@ -1,55 +0,0 @@ - - - - - - - - - - - - - - diff --git a/packages/SystemUI/res/layout/qs_detail_switch.xml b/packages/SystemUI/res/layout/qs_detail_switch.xml deleted file mode 100644 index abb2497fb7bef..0000000000000 --- a/packages/SystemUI/res/layout/qs_detail_switch.xml +++ /dev/null @@ -1,23 +0,0 @@ - - - \ No newline at end of file diff --git a/packages/SystemUI/res/layout/qs_panel.xml b/packages/SystemUI/res/layout/qs_panel.xml index 85b33cc4cc257..20400510a31ae 100644 --- a/packages/SystemUI/res/layout/qs_panel.xml +++ b/packages/SystemUI/res/layout/qs_panel.xml @@ -47,10 +47,6 @@ - - - - - - - - - - - - - - - diff --git a/packages/SystemUI/res/layout/zen_mode_panel.xml b/packages/SystemUI/res/layout/zen_mode_panel.xml deleted file mode 100644 index 58624135b85fe..0000000000000 --- a/packages/SystemUI/res/layout/zen_mode_panel.xml +++ /dev/null @@ -1,170 +0,0 @@ - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - diff --git a/packages/SystemUI/res/values-land/dimens.xml b/packages/SystemUI/res/values-land/dimens.xml index 9d24e9b97da36..01eb09b659f21 100644 --- a/packages/SystemUI/res/values-land/dimens.xml +++ b/packages/SystemUI/res/values-land/dimens.xml @@ -38,11 +38,6 @@ 14dp 12dp - 9dp - 9dp - - 14dp - 12dp 128dp diff --git a/packages/SystemUI/res/values-sw410dp/dimens.xml b/packages/SystemUI/res/values-sw410dp/dimens.xml index d33ee9970f801..7da47e5089be1 100644 --- a/packages/SystemUI/res/values-sw410dp/dimens.xml +++ b/packages/SystemUI/res/values-sw410dp/dimens.xml @@ -20,8 +20,6 @@ - 16dp - 8dp 4dp diff --git a/packages/SystemUI/res/values-sw600dp/dimens.xml b/packages/SystemUI/res/values-sw600dp/dimens.xml index a66ed15c9d841..8f6bde56d5216 100644 --- a/packages/SystemUI/res/values-sw600dp/dimens.xml +++ b/packages/SystemUI/res/values-sw600dp/dimens.xml @@ -65,9 +65,6 @@ 48dp 0dp - - 0dp - 472dp diff --git a/packages/SystemUI/res/values/attrs.xml b/packages/SystemUI/res/values/attrs.xml index e6ab0ff9bd73a..2992859b1ce72 100644 --- a/packages/SystemUI/res/values/attrs.xml +++ b/packages/SystemUI/res/values/attrs.xml @@ -114,13 +114,6 @@ - - - - - - diff --git a/packages/SystemUI/res/values/dimens.xml b/packages/SystemUI/res/values/dimens.xml index fe79f271d0b64..d1f4f1906f337 100644 --- a/packages/SystemUI/res/values/dimens.xml +++ b/packages/SystemUI/res/values/dimens.xml @@ -500,26 +500,10 @@ 4dp @dimen/new_footer_height 48dp - 0dp - 56dp - 56dp - 16dp - 48dp - 20sp - 14sp - 16sp - 14sp - 14sp - 28dp - 16dp + 14sp 36sp - 16dp - 4dp - 24dp - 32dp - 0dp - 20dp + @dimen/status_bar_icon_drawing_size 6dp 4dp @@ -533,9 +517,6 @@ 0dp 28dp - - 24dp - 0dp 2dp @@ -547,8 +528,6 @@ 20dp - @*android:dimen/quick_qs_offset_height - 4dp diff --git a/packages/SystemUI/res/values/strings.xml b/packages/SystemUI/res/values/strings.xml index 6a34adadcffef..3b7e9d46c9537 100644 --- a/packages/SystemUI/res/values/strings.xml +++ b/packages/SystemUI/res/values/strings.xml @@ -609,8 +609,6 @@ Color inversion Color correction - - More settings User settings @@ -1213,9 +1211,6 @@ on %1$s - - Quick Settings, %s. - Hotspot @@ -1730,11 +1725,6 @@ No internet - - Open details. - - - Open %s settings. diff --git a/packages/SystemUI/res/values/styles.xml b/packages/SystemUI/res/values/styles.xml index 9448d3f342b97..5d252fdbd023f 100644 --- a/packages/SystemUI/res/values/styles.xml +++ b/packages/SystemUI/res/values/styles.xml @@ -96,17 +96,12 @@ @*android:string/config_bodyFontFamily - - @@ -120,23 +115,6 @@ ?android:attr/colorError - - - - - - @@ -433,9 +411,6 @@ 3 -