From 43e93f0afc518d20be2138d8d053758771ee954b Mon Sep 17 00:00:00 2001 From: Johannes Gallmann Date: Tue, 21 Mar 2023 11:54:59 +0100 Subject: [PATCH] Fix notification expand-collapse crossfade issue Since the user can drag back and forth, the fadeOut function should not return early, when the view's alpha is already 0. It should allow going away from 0 again. This check was introduced by ag/21061907. Bug: 272263243 Test: Manual: i.e. expanding and collapsing notifications by dragging manually Change-Id: If36327c6db4e440e0d95f51c18035a78226796a0 --- .../src/com/android/systemui/statusbar/CrossFadeHelper.java | 6 ------ 1 file changed, 6 deletions(-) diff --git a/packages/SystemUI/src/com/android/systemui/statusbar/CrossFadeHelper.java b/packages/SystemUI/src/com/android/systemui/statusbar/CrossFadeHelper.java index 5adb58bca886f..63179dac7b8ce 100644 --- a/packages/SystemUI/src/com/android/systemui/statusbar/CrossFadeHelper.java +++ b/packages/SystemUI/src/com/android/systemui/statusbar/CrossFadeHelper.java @@ -77,12 +77,6 @@ public class CrossFadeHelper { */ public static void fadeOut(View view, float fadeOutAmount, boolean remap) { view.animate().cancel(); - - // Don't fade out if already not visible. - if (view.getAlpha() == 0.0f) { - return; - } - if (fadeOutAmount == 1.0f && view.getVisibility() != View.GONE) { view.setVisibility(View.INVISIBLE); } else if (view.getVisibility() == View.INVISIBLE) {