From 1dc13378a2db036a968e307c716587204c0a24a9 Mon Sep 17 00:00:00 2001 From: shubang Date: Tue, 26 May 2020 16:56:05 -0700 Subject: [PATCH] Tuner API: make DvrPlayback.attach/detachFilter no-ops Will mark them @deprecated or @removed in next version Bug: 155435894 Test: make Change-Id: If5bf3604ed10721f80162d54951eb38bb8084646 --- .../android/media/tv/tuner/dvr/DvrPlayback.java | 15 ++++++++++----- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/media/java/android/media/tv/tuner/dvr/DvrPlayback.java b/media/java/android/media/tv/tuner/dvr/DvrPlayback.java index 9971c847dd54d..68071b0b0fe3c 100644 --- a/media/java/android/media/tv/tuner/dvr/DvrPlayback.java +++ b/media/java/android/media/tv/tuner/dvr/DvrPlayback.java @@ -105,28 +105,33 @@ public class DvrPlayback implements AutoCloseable { /** - * Attaches a filter to DVR interface for recording. + * Attaches a filter to DVR interface for playback. * - *

There can be multiple filters attached. Attached filters are independent, so the order - * doesn't matter. + *

This method will be deprecated. Now it's a no-op. + *

Filters opened by {@link Tuner#openFilter} are used for DVR playback. * * @param filter the filter to be attached. * @return result status of the operation. */ @Result public int attachFilter(@NonNull Filter filter) { - return nativeAttachFilter(filter); + // no-op + return Tuner.RESULT_UNAVAILABLE; } /** * Detaches a filter from DVR interface. * + *

This method will be deprecated. Now it's a no-op. + *

Filters opened by {@link Tuner#openFilter} are used for DVR playback. + * * @param filter the filter to be detached. * @return result status of the operation. */ @Result public int detachFilter(@NonNull Filter filter) { - return nativeDetachFilter(filter); + // no-op + return Tuner.RESULT_UNAVAILABLE; } /**