Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge "Log when child views are freed" into tm-qpr-dev

Browse Source
This commit is contained in:
Jeff DeCew
2022-08-11 19:06:44 +00:00
committed by Android (Google) Code Review
parent fece6e2107 9e25f0929c
commit 4355e01640
2 changed files with 15 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
packages/SystemUI/src/com/android/systemui/statusbar/notification/collection/coordinator/PreparationCoordinator.java
View File

@@ -286,7 +286,7 @@ public class PreparationCoordinator implements Coordinator {
if (isInflated(child)) { if (isInflated(child)) {
// TODO: May want to put an animation hint here so view manager knows to treat // TODO: May want to put an animation hint here so view manager knows to treat
// this differently from a regular removal animation // this differently from a regular removal animation
freeNotifViews(child); freeNotifViews(child, "Past last visible group child");
} }
} }
} }
@@ -379,7 +379,8 @@ public class PreparationCoordinator implements Coordinator {
mNotifInflatingFilter.invalidateList("onInflationFinished for " + logKey(entry)); mNotifInflatingFilter.invalidateList("onInflationFinished for " + logKey(entry));
} }
private void freeNotifViews(NotificationEntry entry) { private void freeNotifViews(NotificationEntry entry, String reason) {
mLogger.logFreeNotifViews(entry, reason);
mViewBarn.removeViewForEntry(entry); mViewBarn.removeViewForEntry(entry);
mNotifInflater.releaseViews(entry); mNotifInflater.releaseViews(entry);
// TODO: clear the entry's row here, or even better, stop setting the row on the entry! // TODO: clear the entry's row here, or even better, stop setting the row on the entry!

15
packages/SystemUI/src/com/android/systemui/statusbar/notification/collection/coordinator/PreparationCoordinatorLogger.kt
View File

@@ -31,7 +31,7 @@ class PreparationCoordinatorLogger @Inject constructor(
buffer.log(TAG, LogLevel.DEBUG, { buffer.log(TAG, LogLevel.DEBUG, {
str1 = entry.logKey str1 = entry.logKey
}, { }, {
"NOTIF INFLATED $str1" "Inflation completed for notif $str1"
}) })
} }
@@ -40,7 +40,16 @@ class PreparationCoordinatorLogger @Inject constructor(
str1 = entry.logKey str1 = entry.logKey
str2 = reason str2 = reason
}, { }, {
"NOTIF INFLATION ABORTED $str1 reason=$str2" "Infation aborted for notif $str1 reason=$str2"
})
}
fun logFreeNotifViews(entry: NotificationEntry, reason: String) {
buffer.log(TAG, LogLevel.DEBUG, {
str1 = entry.logKey
str2 = reason
}, {
"Freeing content views for notif $str1 reason=$str2"
}) })
} }
@@ -70,4 +79,4 @@ class PreparationCoordinatorLogger @Inject constructor(
} }
} }
private const val TAG = "PreparationCoordinator" private const val TAG = "PreparationCoordinator"