From 4325c61c4be19a013da23914d479f59a802ed93f Mon Sep 17 00:00:00 2001 From: Julia Reynolds Date: Mon, 25 Jul 2022 10:00:41 -0400 Subject: [PATCH] Scale back channel toast Only show the toast if enabled by the user. Test: Turn off setting and post a notification to an invalid channel Fixes: 231150048 Change-Id: I83a66c60ff4638392814233dfa15c2e0fd0cf9c8 --- .../server/notification/NotificationManagerService.java | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/services/core/java/com/android/server/notification/NotificationManagerService.java b/services/core/java/com/android/server/notification/NotificationManagerService.java index e589080786b55..ddfde33b467bc 100755 --- a/services/core/java/com/android/server/notification/NotificationManagerService.java +++ b/services/core/java/com/android/server/notification/NotificationManagerService.java @@ -6758,9 +6758,8 @@ public class NotificationManagerService extends SystemService { protected void doChannelWarningToast(int forUid, CharSequence toastText) { Binder.withCleanCallingIdentity(() -> { - final int defaultWarningEnabled = Build.IS_DEBUGGABLE ? 1 : 0; final boolean warningEnabled = Settings.Global.getInt(getContext().getContentResolver(), - Settings.Global.SHOW_NOTIFICATION_CHANNEL_WARNINGS, defaultWarningEnabled) != 0; + Settings.Global.SHOW_NOTIFICATION_CHANNEL_WARNINGS, 0) != 0; if (warningEnabled) { Toast toast = Toast.makeText(getContext(), mHandler.getLooper(), toastText, Toast.LENGTH_SHORT);