Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

am a827d7bc: Merge "Other improvements to text cursor movement." into gingerbread

Browse Source 
Merge commit 'a827d7bc347ce6f1a0074dd9fe515919a35a38a9' into gingerbread-plus-aosp

* commit 'a827d7bc347ce6f1a0074dd9fe515919a35a38a9':
  Other improvements to text cursor movement.
This commit is contained in:
Gilles Debunne
2010-10-08 17:21:42 -07:00
committed by Android Git Automerger
parent 37c8ad779f a827d7bc34
commit 42dd7ec9f0
1 changed files with 24 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

37
core/java/android/widget/TextView.java
View File

@@ -6556,7 +6556,10 @@ public class TextView extends View implements ViewTreeObserver.OnPreDrawListener
if (!mFrozenWithFocus || (selStart < 0 || selEnd < 0)) {
// If a tap was used to give focus to that view, move cursor at tap position.
// Has to be done before onTakeFocus, which can be overloaded.
moveCursorToLastTapPosition();
final int lastTapPosition = getLastTapPosition();
if (lastTapPosition >= 0) {
Selection.setSelection((Spannable) mText, lastTapPosition);
}
if (mMovement != null) {
mMovement.onTakeFocus(this, (Spannable) mText, direction);
@@ -6615,6 +6618,10 @@ public class TextView extends View implements ViewTreeObserver.OnPreDrawListener
} else {
terminateTextSelectionMode();
}
if (mSelectionModifierCursorController != null) {
((SelectionModifierCursorController) mSelectionModifierCursorController).resetTouchOffsets();
}
}
startStopMarquee(focused);
@@ -6626,20 +6633,22 @@ public class TextView extends View implements ViewTreeObserver.OnPreDrawListener
super.onFocusChanged(focused, direction, previouslyFocusedRect);
}
private void moveCursorToLastTapPosition() {
private int getLastTapPosition() {
if (mSelectionModifierCursorController != null) {
int mTapToFocusPosition = ((SelectionModifierCursorController)
int lastTapPosition = ((SelectionModifierCursorController)
mSelectionModifierCursorController).getMinTouchOffset();
if (mTapToFocusPosition >= 0) {
if (lastTapPosition >= 0) {
// Safety check, should not be possible.
if (mTapToFocusPosition > mText.length()) {
Log.e(LOG_TAG, "Invalid tap focus position (" + mTapToFocusPosition + " vs "
if (lastTapPosition > mText.length()) {
Log.e(LOG_TAG, "Invalid tap focus position (" + lastTapPosition + " vs "
+ mText.length() + ")");
mTapToFocusPosition = mText.length();
lastTapPosition = mText.length();
}
Selection.setSelection((Spannable) mText, mTapToFocusPosition);
return lastTapPosition;
}
}
return -1;
}
@Override
@@ -7302,10 +7311,8 @@ public class TextView extends View implements ViewTreeObserver.OnPreDrawListener
}
private String getWordForDictionary() {
if (!mContextMenuTriggeredByKey) {
moveCursorToLastTapPosition();
}
long wordLimits = getWordLimitsAt(getSelectionStart());
int seedPosition = mContextMenuTriggeredByKey ? getSelectionStart() : getLastTapPosition();
long wordLimits = getWordLimitsAt(seedPosition);
if (wordLimits >= 0) {
int start = extractRangeStartFromLong(wordLimits);
int end = extractRangeEndFromLong(wordLimits);
@@ -8024,7 +8031,7 @@ public class TextView extends View implements ViewTreeObserver.OnPreDrawListener
SelectionModifierCursorController() {
mStartHandle = new HandleView(this, HandleView.LEFT);
mEndHandle = new HandleView(this, HandleView.RIGHT);
mMinTouchOffset = mMaxTouchOffset = -1;
resetTouchOffsets();
}
public void show() {
@@ -8156,6 +8163,10 @@ public class TextView extends View implements ViewTreeObserver.OnPreDrawListener
return mMaxTouchOffset;
}
public void resetTouchOffsets() {
mMinTouchOffset = mMaxTouchOffset = -1;
}
/**
* @return true iff this controller is currently used to move the selection start.
*/