From 429a3b5f1d94327e5cbb2dc80667af4574bba388 Mon Sep 17 00:00:00 2001
From: James Dong <jdong@google.com>
Date: Mon, 11 May 2009 10:58:03 -0700
Subject: [PATCH] Fix a JNI layer crash due to null camera object passed to
 get_native_camera() The fix will check on the camera object and if it is a
 null object, we throw a NullPointerException; application layer should also
 avoid passing a null java object to MediaRecorder.setCamera().

---
 media/jni/android_media_MediaRecorder.cpp | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/media/jni/android_media_MediaRecorder.cpp b/media/jni/android_media_MediaRecorder.cpp
index 209b09f7c2e7f..cac65d66600aa 100644
--- a/media/jni/android_media_MediaRecorder.cpp
+++ b/media/jni/android_media_MediaRecorder.cpp
@@ -150,6 +150,11 @@ static sp<MediaRecorder> setMediaRecorder(JNIEnv* env, jobject thiz, const sp<Me
 
 static void android_media_MediaRecorder_setCamera(JNIEnv* env, jobject thiz, jobject camera)
 {
+    // we should not pass a null camera to get_native_camera() call.
+    if (camera == NULL) {
+        jniThrowException(env, "java/lang/NullPointerException", "camera object is a NULL pointer");
+        return;
+    }
     sp<Camera> c = get_native_camera(env, camera, NULL);
     sp<MediaRecorder> mr = getMediaRecorder(env, thiz);
     process_media_recorder_call(env, mr->setCamera(c->remote()),